[TASK] Modernize ext:adminpanel
* Use more DI * Avoid MainController being a singleton, have it DI shared * Avoid static state in InMemoryLogWriter * Add various type hints * Streamline annotations * Avoid a useless exception class * Use inject* method for DI in an abstract class to avoid polluting __construct() for consumers. Resolves: #99137 Releases: main Change-Id: I15046da24581fccc1524af6ab3320de6c6880c78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76704 Tested-by:Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- Build/phpstan/phpstan-baseline.neon 0 additions, 5 deletionsBuild/phpstan/phpstan-baseline.neon
- typo3/sysext/adminpanel/Classes/Controller/AjaxController.php 4 additions, 9 deletions...3/sysext/adminpanel/Classes/Controller/AjaxController.php
- typo3/sysext/adminpanel/Classes/Controller/MainController.php 10 additions, 22 deletions...3/sysext/adminpanel/Classes/Controller/MainController.php
- typo3/sysext/adminpanel/Classes/Exceptions/InvalidConfigurationException.php 0 additions, 25 deletions...anel/Classes/Exceptions/InvalidConfigurationException.php
- typo3/sysext/adminpanel/Classes/Log/DoctrineSqlLogger.php 8 additions, 25 deletionstypo3/sysext/adminpanel/Classes/Log/DoctrineSqlLogger.php
- typo3/sysext/adminpanel/Classes/Log/InMemoryLogWriter.php 22 additions, 18 deletionstypo3/sysext/adminpanel/Classes/Log/InMemoryLogWriter.php
- typo3/sysext/adminpanel/Classes/Middleware/SqlLogging.php 3 additions, 8 deletionstypo3/sysext/adminpanel/Classes/Middleware/SqlLogging.php
- typo3/sysext/adminpanel/Classes/ModuleApi/AbstractModule.php 11 additions, 23 deletionstypo3/sysext/adminpanel/Classes/ModuleApi/AbstractModule.php
- typo3/sysext/adminpanel/Classes/ModuleApi/AbstractSubModule.php 2 additions, 2 deletions...sysext/adminpanel/Classes/ModuleApi/AbstractSubModule.php
- typo3/sysext/adminpanel/Classes/ModuleApi/ModuleData.php 1 addition, 1 deletiontypo3/sysext/adminpanel/Classes/ModuleApi/ModuleData.php
- typo3/sysext/adminpanel/Classes/ModuleApi/ModuleDataStorageCollection.php 1 addition, 4 deletions...inpanel/Classes/ModuleApi/ModuleDataStorageCollection.php
- typo3/sysext/adminpanel/Classes/Modules/Debug/Log.php 5 additions, 6 deletionstypo3/sysext/adminpanel/Classes/Modules/Debug/Log.php
- typo3/sysext/adminpanel/Classes/Modules/Debug/PageTitle.php 3 additions, 2 deletionstypo3/sysext/adminpanel/Classes/Modules/Debug/PageTitle.php
- typo3/sysext/adminpanel/Classes/Modules/DebugModule.php 3 additions, 1 deletiontypo3/sysext/adminpanel/Classes/Modules/DebugModule.php
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php 2 additions, 1 deletiontypo3/sysext/adminpanel/Classes/Modules/PreviewModule.php
- typo3/sysext/adminpanel/Classes/Modules/TsDebug/TypoScriptWaterfall.php 3 additions, 5 deletions...dminpanel/Classes/Modules/TsDebug/TypoScriptWaterfall.php
- typo3/sysext/adminpanel/Classes/Service/ConfigurationService.php 1 addition, 4 deletions...ysext/adminpanel/Classes/Service/ConfigurationService.php
- typo3/sysext/adminpanel/Classes/Service/ModuleLoader.php 2 additions, 3 deletionstypo3/sysext/adminpanel/Classes/Service/ModuleLoader.php
- typo3/sysext/adminpanel/Configuration/Services.yaml 19 additions, 0 deletionstypo3/sysext/adminpanel/Configuration/Services.yaml
- typo3/sysext/adminpanel/Tests/Unit/Fixtures/MainModuleFixture.php 0 additions, 23 deletions...sext/adminpanel/Tests/Unit/Fixtures/MainModuleFixture.php
Please register or sign in to comment