[BUGFIX] Respect '_language' argument for typoLink and LinkHandler
This patch fixes a bug where a t3 page URI with _language != 0 was resolved to a page in the default language. This caused automatically generated redirects to translated pages to redirect to the page in the default language. We now use the same override handling for the '_language' parameter (as already existed for 'L') when t3 page URIs are resolved. Also, we ensure that both parameters are always removed when the final URL is generated. Furthermore, this patch adds tests to cover these cases. Using the historical 'L' parameter still works and has been added to be handled as language override. Background information: The '_language parameter' is the preferred parameter to be used to specify the language in a t3 URI, not 'L'. The behaviour of creating auto redirects on slug changes was changed previously: The target was added as LinkHandler URI (instead of the path). Along with this change, the '_language' parameter was used to ensure the target URL is generated in the needed language (#89327). This introduced a problem where a redirect always redirected to the page in default language if a t3: page URI was used with '_language'. Resolves: #96043 Related: #89327 Releases: master, 11.5, 10.4 Change-Id: I95bdeff4827eed3be30528c02331b9c9ff2836b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72242 Tested-by:core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
Benni Mack <benni@typo3.org>
Showing
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php 12 additions, 3 deletionstypo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/TypoLinkScenario.yaml 12 additions, 0 deletions...ts/Functional/SiteHandling/Fixtures/TypoLinkScenario.yaml
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php 52 additions, 0 deletions...d/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php
Please register or sign in to comment