[TASK] FormEngine inline refactoring
FormEngine splits in two parts: Data compilation and preparation and rendering. The patch separates the inline related data preparation out of the render containers and moves it into the data provider. TcaInline provider now resolves and compiles children and adds them to processedTca[columns][$field][children], so InlineControlContainer can just loop over them to render children. InlineRecordContainer, the second inline container that takes care of rendering single children records now no longer receives the full parent data, but only the specific child data array it should render. This leads to better encapsulation and allows some future performance improvements. While the inline stuff is still a very complex thing, this last main structural FormEngine change takes the opportunity to comment further details and dependencies and it simplifies the structures by better separation of concerns. Change-Id: Ia0ed276d7fc6f541f8ae27eaac3e17e3b8714ddf Resolves: #70490 Releases: master Reviewed-on: http://review.typo3.org/43755 Reviewed-by:Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
Showing
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php 460 additions, 355 deletions...t/backend/Classes/Controller/FormInlineAjaxController.php
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php 3 additions, 0 deletions...ckend/Classes/Form/Container/FlexFormElementContainer.php
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php 81 additions, 63 deletions...backend/Classes/Form/Container/InlineControlContainer.php
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php 72 additions, 235 deletions.../backend/Classes/Form/Container/InlineRecordContainer.php
- typo3/sysext/backend/Classes/Form/FormDataCompiler.php 16 additions, 1 deletiontypo3/sysext/backend/Classes/Form/FormDataCompiler.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractDatabaseRecordProvider.php 0 additions, 2 deletions.../Form/FormDataProvider/AbstractDatabaseRecordProvider.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowInitializeNew.php 2 additions, 0 deletions...lasses/Form/FormDataProvider/DatabaseRowInitializeNew.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseUserPermissionCheck.php 2 additions, 0 deletions...ses/Form/FormDataProvider/DatabaseUserPermissionCheck.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php 217 additions, 51 deletions...ysext/backend/Classes/Form/FormDataProvider/TcaInline.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineConfiguration.php 192 additions, 0 deletions.../Classes/Form/FormDataProvider/TcaInlineConfiguration.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineExpandCollapseState.php 56 additions, 0 deletions...es/Form/FormDataProvider/TcaInlineExpandCollapseState.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php 1 addition, 0 deletions...nd/Classes/Form/FormDataProvider/TcaInputPlaceholders.php
- typo3/sysext/backend/Classes/Form/InlineRelatedRecordResolver.php 0 additions, 259 deletions...sext/backend/Classes/Form/InlineRelatedRecordResolver.php
- typo3/sysext/backend/Classes/Form/InlineStackProcessor.php 12 additions, 11 deletionstypo3/sysext/backend/Classes/Form/InlineStackProcessor.php
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php 0 additions, 85 deletions...sysext/backend/Classes/Form/Utility/FormEngineUtility.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php 522 additions, 0 deletions...Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineExpandCollapseStateTest.php 65 additions, 0 deletions...orm/FormDataProvider/TcaInlineExpandCollapseStateTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInputPlaceholdersTest.php 5 additions, 5 deletions...s/Unit/Form/FormDataProvider/TcaInputPlaceholdersTest.php
- typo3/sysext/backend/Tests/Unit/Form/InlineStackProcessorTest.php 32 additions, 3 deletions...sext/backend/Tests/Unit/Form/InlineStackProcessorTest.php
- typo3/sysext/core/Configuration/DefaultConfiguration.php 34 additions, 4 deletionstypo3/sysext/core/Configuration/DefaultConfiguration.php
Please register or sign in to comment