Skip to content
Snippets Groups Projects
Commit ea143a3c authored by Oliver Bartsch's avatar Oliver Bartsch
Browse files

[BUGFIX] Link root page title in site configuration module

To be consistent with the other listings in the
backend is the root page title of a site in the
site configuration module now linked, allowing
to edit the corresponding site configuration.

Additionally does the link as well as the
edit button now use a dedicated label instead
of a generic one.

Resolves: #103695
Releases: main, 12.4
Change-Id: Ice46e82587cdc36daa6275f6eec2c46909e8a071
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83950


Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarJasmina Ließmann <minapokhalo+typo3@gmail.com>
Reviewed-by: default avatarOliver Bartsch <bo@cedev.de>
Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarJasmina Ließmann <minapokhalo+typo3@gmail.com>
Tested-by: default avatarOliver Bartsch <bo@cedev.de>
parent 5cafe4e7
Branches
Tags
No related merge requests found
...@@ -24,6 +24,9 @@ ...@@ -24,6 +24,9 @@
<trans-unit id="overview.addSiteConfiguration" resname="overview.addSiteConfiguration"> <trans-unit id="overview.addSiteConfiguration" resname="overview.addSiteConfiguration">
<source>Add new site configuration for this site</source> <source>Add new site configuration for this site</source>
</trans-unit> </trans-unit>
<trans-unit id="overview.editSiteConfiguration" resname="overview.editSiteConfiguration">
<source>Edit site configuration</source>
</trans-unit>
<trans-unit id="overview.deleteSiteConfiguration" resname="overview.deleteSiteConfiguration"> <trans-unit id="overview.deleteSiteConfiguration" resname="overview.deleteSiteConfiguration">
<source>Delete site configuration</source> <source>Delete site configuration</source>
</trans-unit> </trans-unit>
......
...@@ -92,7 +92,16 @@ ...@@ -92,7 +92,16 @@
</button> </button>
</td> </td>
<td class="align-top"> <td class="align-top">
{rootPage.title} <f:if condition="{page.siteIdentifier}">
<f:then>
<f:be.link route="site_configuration.edit" parameters="{site: page.siteIdentifier}" title="{f:translate(key:'LLL:EXT:backend/Resources/Private/Language/locallang_siteconfiguration.xlf:overview.editSiteConfiguration')}">
{rootPage.title}
</f:be.link>
</f:then>
<f:else>
{rootPage.title}
</f:else>
</f:if>
</td> </td>
<td class="align-top"> <td class="align-top">
<f:if condition="{page.siteIdentifier}"> <f:if condition="{page.siteIdentifier}">
...@@ -137,7 +146,7 @@ ...@@ -137,7 +146,7 @@
<td class="align-top nowrap col-control"> <td class="align-top nowrap col-control">
<div class="btn-group"> <div class="btn-group">
<f:if condition="{page.siteIdentifier}"> <f:if condition="{page.siteIdentifier}">
<f:be.link route="site_configuration.edit" parameters="{site: page.siteIdentifier}" title="{f:translate(key:'LLL:EXT:core/Resources/Private/Language/locallang_common.xlf:edit')}" class="btn btn-default"> <f:be.link route="site_configuration.edit" parameters="{site: page.siteIdentifier}" title="{f:translate(key:'LLL:EXT:backend/Resources/Private/Language/locallang_siteconfiguration.xlf:overview.editSiteConfiguration')}" class="btn btn-default">
<core:icon identifier="actions-open" /> <core:icon identifier="actions-open" />
</f:be.link> </f:be.link>
<button <button
......
...@@ -38,7 +38,7 @@ final class SiteModuleCest ...@@ -38,7 +38,7 @@ final class SiteModuleCest
$I->see('Site Configuration', 'h1'); $I->see('Site Configuration', 'h1');
$I->amGoingTo('edit an automatically created site configuration'); $I->amGoingTo('edit an automatically created site configuration');
$I->click('Edit'); $I->click('Edit site configuration');
$I->waitForElementNotVisible('#t3js-ui-block'); $I->waitForElementNotVisible('#t3js-ui-block');
$I->see('Edit Site Configuration', 'h1'); $I->see('Edit Site Configuration', 'h1');
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment