Skip to content
Snippets Groups Projects
Commit e52a91c8 authored by Sascha Egerer's avatar Sascha Egerer Committed by Benni Mack
Browse files

[BUGFIX] Prevent null value being passed to hash_equals

The second parameter of hash_equals must be a string but could be a
null value in the FileDumpController. It is ensured now that the
value is always a string.

Resolves: #86599
Releases: master, 8.7
Change-Id: Iaf682b405be6712aa31603521a2d873b4c3bcb89
Reviewed-on: https://review.typo3.org/58596


Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarMathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarBenni Mack <benni@typo3.org>
parent 6595aa54
No related merge requests found
<?php
declare(strict_types = 1);
namespace TYPO3\CMS\Core\Controller;
/*
......@@ -95,10 +97,10 @@ class FileDumpController
/**
* @param ServerRequestInterface $request
* @param string $parameter
* @return mixed|null
* @return string
*/
protected function getGetOrPost(ServerRequestInterface $request, $parameter)
protected function getGetOrPost(ServerRequestInterface $request, string $parameter): string
{
return $request->getParsedBody()[$parameter] ?? $request->getQueryParams()[$parameter] ?? null;
return (string)($request->getParsedBody()[$parameter] ?? $request->getQueryParams()[$parameter] ?? '');
}
}
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment