[!!!][TASK] Cleanup and harden Extbase Request
The Extbase Request has been turned into a PSR-7 decorator in v11. Most interface changes have not been enforced in v11 though, since that would have been breaking at this point in the release cycle. With v12, we can now activate the RequestInterface changes. The patch does this, and migrates the "setX()" that violate PSR-7 request immutability towards their 'withX()' counterparts which create new objects. The patch adds quite a bit of syntactic sugar to consuming classes: core phpstan is significantly more happy and extbase extension devs benefit from improved type hints and interface coverage. Change-Id: I111be724fd4e5d6dc9b1305efa31b7c90952730e Resolves: #98370 Related: #94428 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75749 Tested-by:Lina Wolf <112@linawolf.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- Build/phpstan/phpstan-baseline.neon 0 additions, 180 deletionsBuild/phpstan/phpstan-baseline.neon
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php 1 addition, 1 deletion...ysext/beuser/Classes/Controller/BackendUserController.php
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98370-ExtbaseRequestCleanupAndHardening.rst 75 additions, 0 deletions...12.0/Breaking-98370-ExtbaseRequestCleanupAndHardening.rst
- typo3/sysext/extbase/Classes/Core/Bootstrap.php 2 additions, 2 deletionstypo3/sysext/extbase/Classes/Core/Bootstrap.php
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php 5 additions, 5 deletions...ysext/extbase/Classes/Mvc/Controller/ActionController.php
- typo3/sysext/extbase/Classes/Mvc/Controller/MvcPropertyMappingConfigurationService.php 4 additions, 1 deletion...Mvc/Controller/MvcPropertyMappingConfigurationService.php
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php 10 additions, 16 deletionstypo3/sysext/extbase/Classes/Mvc/Dispatcher.php
- typo3/sysext/extbase/Classes/Mvc/ExtbaseRequestParameters.php 24 additions, 34 deletions...3/sysext/extbase/Classes/Mvc/ExtbaseRequestParameters.php
- typo3/sysext/extbase/Classes/Mvc/Request.php 8 additions, 153 deletionstypo3/sysext/extbase/Classes/Mvc/Request.php
- typo3/sysext/extbase/Classes/Mvc/RequestInterface.php 23 additions, 66 deletionstypo3/sysext/extbase/Classes/Mvc/RequestInterface.php
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php 1 addition, 7 deletionstypo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php 4 additions, 8 deletionstypo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php 6 additions, 6 deletions...unctional/Mvc/Controller/ActionControllerArgumentTest.php
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php 9 additions, 9 deletions.../Tests/Functional/Mvc/Controller/ActionControllerTest.php
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php 6 additions, 6 deletions...ctional/Mvc/Controller/ControllerArgumentsMappingTest.php
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php 15 additions, 15 deletions...ctional/Mvc/Validation/ActionControllerValidationTest.php
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php 16 additions, 11 deletions...Controller/MvcPropertyMappingConfigurationServiceTest.php
- typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php 31 additions, 69 deletionstypo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php
- typo3/sysext/extensionmanager/Classes/Controller/AbstractController.php 2 additions, 2 deletions...xtensionmanager/Classes/Controller/AbstractController.php
- typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php 26 additions, 10 deletions...felogin/Classes/Controller/PasswordRecoveryController.php
Please register or sign in to comment