Skip to content
Snippets Groups Projects
Commit d5dd2b9a authored by Oliver Bartsch's avatar Oliver Bartsch
Browse files

[BUGFIX] Fix extension upload form

Submitting the extension upload form in the
extension manager module, without adding
an extension file, previously triggered an
exception.

Actually those exceptions should have been
caught in the corresponding action and
transformed into a flash message. This
however did not happen because the catch
block calls a method, which again throws an
exception, in case no or an invalid file(name)
is given.

To fix this, a dedicated Exception is now being
thrown when checking the file in checkFileName().
This is the first and most important check and
should therefore be handled independently.
This means, no further code, especially when
relying on the submitted file, should be executed
when this exception was caught.

As an UX improvement, the "required" attribute
is added to the file input field, preventing unintended
submitting of the form before an extension file was
added.

Resolves: #94183
Releases: master, 10.4
Change-Id: I9a8b34f2123f14529b984cc2672215420804075b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69225


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarDaniel Goerz <daniel.goerz@posteo.de>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: default avatarDaniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarOliver Bartsch <bo@cedev.de>
parent 5ee70254
Branches
Tags
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment