[TASK] Remove special singleton handling of makeInstanceService
Calling GeneralUtility::makeInstanceService() stores the instance as "persistent object". Since TYPO3 4.x this has been dealt with SingletonInterface, which allows far more flexibility in various places, as throughout the ENTIRE TYPO3 Core already. The special handling of having GeneralUtility::makeInstanceService() stores its own Singleton instances is removed, as the method calls `GeneralUtility::makeInstance()` as well, which does handle the SingletonInterface anyway. For services in general (like Authentication Services), it is useful to not have them as singleton. The current process within "makeInstanceService()" now allows to properly "reset()" the functionality anyway by re-calling "init()", which itself calls "reset()" as well. As there are no contracts (interfaces) for Services currently, this should not interfere with anything existing services. Resolves: #88588 Releases: master Change-Id: Iba54715c04e510003c095578a237524ebe9f374f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61090 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Daniel Sattler <sattler@b13.de> Reviewed-by:
Benni Mack <benni@typo3.org>
Please register or sign in to comment