[BUGFIX] Remove caches for page title and meta tag
By concept for frontend rendering the page title and meta tags are not meant to be stored in page cache in order to allow non cachable plugins to modify those. Currently both page title and meta tags are stored in separate cache entries, which violates the concept above and unnecessarily tightly couples those code parts to the TypoScriptFrontendController and internal logic of it. This patch removes these caches. In order to properly handle the uncached rendering state, we make sure the meta tag registry is properly serialized with all managers. Resolves: #88179 Releases: master, 9.5 Change-Id: If5200398bf9ab9db09ab97403c976d82cb33d01d Signed-off-by:Frank Naegler <frank.naegler@typo3.org> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60520 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Richard Haeser <richard@maxserv.com>
Showing
- typo3/sysext/core/Classes/MetaTag/AbstractMetaTagManager.php 1 addition, 3 deletionstypo3/sysext/core/Classes/MetaTag/AbstractMetaTagManager.php
- typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php 1 addition, 3 deletionstypo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php
- typo3/sysext/core/Classes/MetaTag/MetaTagManagerRegistry.php 15 additions, 5 deletionstypo3/sysext/core/Classes/MetaTag/MetaTagManagerRegistry.php
- typo3/sysext/core/Classes/Page/PageRenderer.php 10 additions, 32 deletionstypo3/sysext/core/Classes/Page/PageRenderer.php
- typo3/sysext/core/Classes/PageTitle/PageTitleProviderManager.php 1 addition, 47 deletions...ysext/core/Classes/PageTitle/PageTitleProviderManager.php
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Classes/Controller/MetaPluginController.php 43 additions, 0 deletions...ons/test_meta/Classes/Controller/MetaPluginController.php
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Classes/PageTitle/CustomPageTitleProvider.php 26 additions, 0 deletions...s/test_meta/Classes/PageTitle/CustomPageTitleProvider.php
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page1.typoscript 12 additions, 0 deletions...sions/test_meta/Configuration/TypoScript/page1.typoscript
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page2.typoscript 23 additions, 0 deletions...sions/test_meta/Configuration/TypoScript/page2.typoscript
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page3.typoscript 23 additions, 0 deletions...sions/test_meta/Configuration/TypoScript/page3.typoscript
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page4.typoscript 23 additions, 0 deletions...sions/test_meta/Configuration/TypoScript/page4.typoscript
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/Configuration/TypoScript/page5.typoscript 23 additions, 0 deletions...sions/test_meta/Configuration/TypoScript/page5.typoscript
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta/ext_emconf.php 20 additions, 0 deletions...s/Functional/Fixtures/Extensions/test_meta/ext_emconf.php
- typo3/sysext/core/Tests/Functional/Fixtures/Scenarios/pages_with_plugins_seo_meta.xml 33 additions, 0 deletions...tional/Fixtures/Scenarios/pages_with_plugins_seo_meta.xml
- typo3/sysext/core/Tests/Functional/MetaDataHandling/PluginsTest.php 125 additions, 0 deletions...xt/core/Tests/Functional/MetaDataHandling/PluginsTest.php
Please register or sign in to comment