[TASK] FormEngine: Move SelectTree processing into a data provider
The handling of select form elements with renderType "selectTree" has been cleanly separated into a dedicated pair of element renderer and data provider. Methods used by the default select item provider as well as the tree item provider have been moved into the AbstractItemProvider, the usage of the AbstractItemProvider class has been cleaned up and is now limited to data providers that deal with items. Preparing the javascript for the tree rendering has been moved into a dedicated method in the SelectTreeElement. TcaSelectTreeItemsTest only covers the special data parsing/preparation needed for the tree display, all common test cases for select item handling are covered in TcaSelectItemsTest which covers the methods provided by AbstractItemProvider. Resolves: #69728 Releases: master Change-Id: Idabb99263fe8dc860e4ec19c26a8cfe5b5a61fa3 Reviewed-on: https://review.typo3.org/43252 Reviewed-by:Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php 147 additions, 161 deletions...sysext/backend/Classes/Form/Element/SelectTreeElement.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php 1127 additions, 0 deletions...nd/Classes/Form/FormDataProvider/AbstractItemProvider.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/ReturnUrl.php 1 addition, 1 deletion...ysext/backend/Classes/Form/FormDataProvider/ReturnUrl.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexFetch.php 1 addition, 1 deletion...xt/backend/Classes/Form/FormDataProvider/TcaFlexFetch.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexPrepare.php 1 addition, 1 deletion.../backend/Classes/Form/FormDataProvider/TcaFlexPrepare.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php 1 addition, 1 deletion.../backend/Classes/Form/FormDataProvider/TcaFlexProcess.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineConfiguration.php 1 addition, 1 deletion.../Classes/Form/FormDataProvider/TcaInlineConfiguration.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineExpandCollapseState.php 1 addition, 1 deletion...es/Form/FormDataProvider/TcaInlineExpandCollapseState.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php 10 additions, 1 deletion...nd/Classes/Form/FormDataProvider/TcaInputPlaceholders.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php 9 additions, 1051 deletions.../backend/Classes/Form/FormDataProvider/TcaSelectItems.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php 189 additions, 0 deletions...kend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php 48 additions, 0 deletions...d/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php 119 additions, 0 deletions...sts/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php
- typo3/sysext/compatibility6/Classes/Form/FormDataProvider/TcaFlexProcess.php 1 addition, 1 deletion...ibility6/Classes/Form/FormDataProvider/TcaFlexProcess.php
- typo3/sysext/core/Configuration/DefaultConfiguration.php 18 additions, 3 deletionstypo3/sysext/core/Configuration/DefaultConfiguration.php
Please register or sign in to comment