[TASK] Avoid runtime overriding GLOBALS in functional tests
The InternalResponseContext class of the testing-framework provides method withGlobalSettings() which can be used to set arbitrary globals when executing a frontend sub request. It is used in various tests to set some TYPO3_CONF_VARS. The testing-framework already provides class property $configurationToUseInTestInstance to set TYPO3_CONF_VARS on a per test-case level. The patch migrates tests towards this property and avoids using an AdditionalConfiguration fixture file that is also used to set some TYPO3_CONF_VARS. Resolves: #96244 Releases: main, 11.5 Change-Id: Ie34a449075d1c1bacb1380dd5e79e3c48978bfe4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72506 Tested-by:Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72509 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php 8 additions, 5 deletions...tional/DataHandling/AbstractDataHandlerActionTestCase.php
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php 2 additions, 4 deletions...sts/Functional/DataHandling/Regular/Modify/ActionTest.php
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/AdditionalConfiguration.php 0 additions, 15 deletions.../Functional/Fixtures/Frontend/AdditionalConfiguration.php
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php 0 additions, 9 deletions...unctional/Mvc/Controller/ActionControllerArgumentTest.php
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php 0 additions, 1 deletion...ests/Functional/Persistence/TranslatedSiteContentTest.php
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/SecureHtmlRenderingTest.php 10 additions, 31 deletions...nt/Tests/Functional/Rendering/SecureHtmlRenderingTest.php
- typo3/sysext/fluid_styled_content/Tests/FunctionalDeprecated/Rendering/SecureHtmlRenderingTest.php 10 additions, 31 deletions...unctionalDeprecated/Rendering/SecureHtmlRenderingTest.php
- typo3/sysext/frontend/Tests/Functional/Middleware/BackendUserAuthenticatorTest.php 2 additions, 6 deletions...ts/Functional/Middleware/BackendUserAuthenticatorTest.php
- typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedSiteContentRenderingTest.php 0 additions, 1 deletion...unctional/Rendering/LocalizedSiteContentRenderingTest.php
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php 8 additions, 5 deletions...tend/Tests/Functional/Rendering/TitleTagRenderingTest.php
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php 8 additions, 5 deletions...end/Tests/Functional/Rendering/UriPrefixRenderingTest.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php 18 additions, 19 deletions...ontend/Tests/Functional/SiteHandling/AbstractTestCase.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EidRequestTest.php 1 addition, 13 deletions...frontend/Tests/Functional/SiteHandling/EidRequestTest.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/AbstractEnhancerLinkGeneratorTestCase.php 2 additions, 17 deletions...erLinkGenerator/AbstractEnhancerLinkGeneratorTestCase.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/DefaultExtbaseControllerTest.php 2 additions, 4 deletions...ng/EnhancerLinkGenerator/DefaultExtbaseControllerTest.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/LocaleModifierTest.php 1 addition, 2 deletions...SiteHandling/EnhancerLinkGenerator/LocaleModifierTest.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/PersistedAliasMapperTest.php 1 addition, 2 deletions...ndling/EnhancerLinkGenerator/PersistedAliasMapperTest.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/PersistedPatternMapperTest.php 1 addition, 2 deletions...ling/EnhancerLinkGenerator/PersistedPatternMapperTest.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/StaticRangeMapperTest.php 1 addition, 2 deletions...eHandling/EnhancerLinkGenerator/StaticRangeMapperTest.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/StaticValueMapperTest.php 1 addition, 2 deletions...eHandling/EnhancerLinkGenerator/StaticValueMapperTest.php
Please register or sign in to comment