[TASK] Cleanup ExtensionManager slot in ext:documentation

Only render one empty-empty icon and use that multiple times.

Resolves: #70419
Releases: master
Change-Id: I1c7a01ccdfece03a11883d0ccf2a62086e2a6e46
Reviewed-on: http://review.typo3.org/43831


Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

typo3/sysext/documentation/Classes/Slots/ExtensionManager.php

@@ -75,9 +75,10 @@ class ExtensionManager {
 			}
 		} else {
 			$iconFactory = GeneralUtility::makeInstance(IconFactory::class);
-			$actions[] = '<span class="btn btn-default disabled">' . $iconFactory->getIcon('empty-empty', Icon::SIZE_SMALL)->render() . '</span>';
-			$actions[] = '<span class="btn btn-default disabled">' . $iconFactory->getIcon('empty-empty', Icon::SIZE_SMALL)->render() . '</span>';
-			$actions[] = '<span class="btn btn-default disabled">' . $iconFactory->getIcon('empty-empty', Icon::SIZE_SMALL)->render() . '</span>';
+			$emptyIcon = $iconFactory->getIcon('empty-empty', Icon::SIZE_SMALL)->render();
+			$actions[] = '<span class="btn btn-default disabled">' . $emptyIcon . '</span>';
+			$actions[] = '<span class="btn btn-default disabled">' . $emptyIcon . '</span>';
+			$actions[] = '<span class="btn btn-default disabled">' . $emptyIcon . '</span>';
 		}
 	}