[BUGFIX] Show cookie warning only for successful authentication

The login dialog may show a cookie warning.
This has only to be shown if the authentication was successful, but the
cookie has not been accepted by the browser.

Resolves: #93492
Releases: master, 10.4
Change-Id: I5d8409357e9db1ed73f38862d8a1586580dab6ca
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68334


Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>

typo3/sysext/felogin/Classes/Controller/LoginController.php

@@ -121,7 +121,7 @@ class LoginController extends AbstractLoginFormController
         $this->configuration = RedirectConfiguration::fromSettings($this->settings);
 
         if ($this->isLoginOrLogoutInProgress() && !$this->isRedirectDisabled()) {
-            if (!$this->userAspect->isLoggedIn() && $this->userService->cookieWarningRequired()) {
+            if ($this->userAspect->isLoggedIn() && $this->userService->cookieWarningRequired()) {
                 $this->showCookieWarning = true;
                 return;
             }