Skip to content
Snippets Groups Projects
Commit 92e04f10 authored by Andrzej Kołbuc's avatar Andrzej Kołbuc Committed by Christian Kuhn
Browse files

[BUGFIX] Remove unnecessary html tags

Labels are rendered by CshViewHelper which do htmlspecialchars on it. Next step todo is change whole additional fields layout and prepare translations.

Resolves: #93888
Releases: master, 10.4
Change-Id: I19d12951a030977384ee3a923823990fe97e9211
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70536


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarkharaf <k.haraf@macopedia.com>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarkharaf <k.haraf@macopedia.com>
Reviewed-by: default avatarRudy Gnodde <rudy@famouswolf.com>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent 0501c0ea
No related merge requests found
...@@ -230,7 +230,7 @@ class ExecuteSchedulableCommandAdditionalFieldProvider implements AdditionalFiel ...@@ -230,7 +230,7 @@ class ExecuteSchedulableCommandAdditionalFieldProvider implements AdditionalFiel
{ {
return [ return [
'code' => '', 'code' => '',
'label' => '<strong>' . $description . '</strong>' 'label' => $description
]; ];
} }
...@@ -324,7 +324,7 @@ class ExecuteSchedulableCommandAdditionalFieldProvider implements AdditionalFiel ...@@ -324,7 +324,7 @@ class ExecuteSchedulableCommandAdditionalFieldProvider implements AdditionalFiel
*/ */
protected function getArgumentLabel(InputArgument $argument): string protected function getArgumentLabel(InputArgument $argument): string
{ {
return 'Argument: ' . $argument->getName() . '. <em>' . htmlspecialchars($argument->getDescription()) . '</em>'; return 'Argument: ' . $argument->getName() . '. ' . htmlspecialchars($argument->getDescription());
} }
/** /**
...@@ -335,7 +335,7 @@ class ExecuteSchedulableCommandAdditionalFieldProvider implements AdditionalFiel ...@@ -335,7 +335,7 @@ class ExecuteSchedulableCommandAdditionalFieldProvider implements AdditionalFiel
*/ */
protected function getOptionLabel(InputOption $option): string protected function getOptionLabel(InputOption $option): string
{ {
return 'Option: ' . htmlspecialchars($option->getName()) . '. <em>' . htmlspecialchars($option->getDescription()) . '</em>'; return 'Option: ' . htmlspecialchars($option->getName()) . '. ' . htmlspecialchars($option->getDescription());
} }
/** /**
...@@ -428,7 +428,7 @@ class ExecuteSchedulableCommandAdditionalFieldProvider implements AdditionalFiel ...@@ -428,7 +428,7 @@ class ExecuteSchedulableCommandAdditionalFieldProvider implements AdditionalFiel
$inputTag->addAttribute('type', 'text'); $inputTag->addAttribute('type', 'text');
$inputTag->addAttribute('value', $currentValue); $inputTag->addAttribute('value', $currentValue);
$inputTag->addAttribute('class', 'form-control'); $inputTag->addAttribute('class', 'form-control');
$html .= $inputTag->render(); $html .= $inputTag->render();
} }
return $html; return $html;
......
...@@ -184,7 +184,7 @@ ...@@ -184,7 +184,7 @@
<source>Amount of tasks without found class</source> <source>Amount of tasks without found class</source>
</trans-unit> </trans-unit>
<trans-unit id="label.schedulableCommandName" resname="label.schedulableCommandName"> <trans-unit id="label.schedulableCommandName" resname="label.schedulableCommandName">
<source><![CDATA[Schedulable Command. <em>Save and reopen to define command arguments</em>]]></source> <source>Schedulable Command. Save and reopen to define command arguments</source>
</trans-unit> </trans-unit>
<trans-unit id="label.saveAndCreateNewTask" resname="label.saveAndCreateNewTask"> <trans-unit id="label.saveAndCreateNewTask" resname="label.saveAndCreateNewTask">
<source>Save and create new task</source> <source>Save and create new task</source>
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment