[BUGFIX] FormEngine: Inline getDynamicTabMenu
getDynamicTabMenu() from DocumentTemplate is one of the last pieces where FormEngine indirectly calls PageRenderer to load JS stuff instead of returning those via the return structure of FormEngine. This leads to missing JS if tabs are added via ajax dom modification and parent has none yet. The patch copies parts of the code to the FormEngine, re-uses the template, but strips the method down to FormEngines need. As a result getTabMenuId() can be deprecated in DocumentTemplate and removed in ModuleTemplate. The patch then re-routes other usages of getDynamicTabMenu from DocumentTemplate to ModuleTemplate, removes another obsolete parameter in there and deprecates the method in DocumentTemplate. Resolves: #69729 Releases: master Change-Id: Ibb94f036d052d5bb9eb4b85efb434b8a05c7755e Reviewed-on: https://review.typo3.org/44269 Reviewed-by:Jan Helke <typo3@helke.de> Tested-by:
Jan Helke <typo3@helke.de> Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/backend/Classes/Form/Container/AbstractContainer.php 24 additions, 0 deletions...sext/backend/Classes/Form/Container/AbstractContainer.php
- typo3/sysext/backend/Classes/Form/Container/FlexFormTabsContainer.php 8 additions, 24 deletions.../backend/Classes/Form/Container/FlexFormTabsContainer.php
- typo3/sysext/backend/Classes/Form/Container/TabsContainer.php 7 additions, 24 deletions...3/sysext/backend/Classes/Form/Container/TabsContainer.php
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php 0 additions, 1 deletiontypo3/sysext/backend/Classes/Form/FormResultCompiler.php
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php 5 additions, 1 deletiontypo3/sysext/backend/Classes/Template/DocumentTemplate.php
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php 6 additions, 26 deletionstypo3/sysext/backend/Classes/Template/ModuleTemplate.php
- typo3/sysext/compatibility6/Classes/Form/Container/FlexFormTabsContainer.php 8 additions, 22 deletions...ibility6/Classes/Form/Container/FlexFormTabsContainer.php
- typo3/sysext/core/Documentation/Changelog/7.2/Deprecation-65111-getDynTabMenu.rst 1 addition, 1 deletion...ntation/Changelog/7.2/Deprecation-65111-getDynTabMenu.rst
- typo3/sysext/core/Documentation/Changelog/7.5/Breaking-69795-UnusedDTMTabmenuCodeRemoved.rst 1 addition, 1 deletion...ngelog/7.5/Breaking-69795-UnusedDTMTabmenuCodeRemoved.rst
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-60712-GetDynamicTabMenu.rst 21 additions, 0 deletions.../Changelog/master/Deprecation-60712-GetDynamicTabMenu.rst
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php 5 additions, 1 deletion...sext/linkvalidator/Classes/Report/LinkValidatorReport.php
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php 1 addition, 1 deletion...sysext/setup/Classes/Controller/SetupModuleController.php
Please register or sign in to comment