Skip to content
Snippets Groups Projects
Commit 89ad74e6 authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[BUGFIX] FormEngine: Inline getDynamicTabMenu

getDynamicTabMenu() from DocumentTemplate is one of the last pieces
where FormEngine indirectly calls PageRenderer to load JS stuff
instead of returning those via the return structure of FormEngine.
This leads to missing JS if tabs are added via ajax dom modification
and parent has none yet.
The patch copies parts of the code to the FormEngine, re-uses the
template, but strips the method down to FormEngines need. As a result
getTabMenuId() can be deprecated in DocumentTemplate and removed in
ModuleTemplate. The patch then re-routes other usages of
getDynamicTabMenu from DocumentTemplate to ModuleTemplate, removes
another obsolete parameter in there and deprecates the method in
DocumentTemplate.

Resolves: #69729
Releases: master
Change-Id: Ibb94f036d052d5bb9eb4b85efb434b8a05c7755e
Reviewed-on: https://review.typo3.org/44269


Reviewed-by: default avatarJan Helke <typo3@helke.de>
Tested-by: default avatarJan Helke <typo3@helke.de>
Reviewed-by: default avatarMorton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: default avatarMorton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent 14e4e014
Branches
Tags
Showing
with 87 additions and 102 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment