[TASK] Remove GFX/im_mask_temp_ext_noloss setting

im_mask_temp_ext_noloss setting is a bugfix for a no longer supported
Image Magick 5 version. It can be removed.

Change-Id: I1001c3fc8fa924ec16e24a9e790a0decf2771bcc
Resolves: #52012
Releases: 6.2
Reviewed-on: https://review.typo3.org/23837
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php

@@ -126,7 +126,7 @@ class LocalCropScaleMaskHelper {
 					$tempScale['m_mask'] = $tmpStr . '_mask.' . $temporaryExtension;
 					$gifBuilder->imageMagickExec($maskImage->getForLocalProcessing(TRUE), $tempScale['m_mask'], $command . $negate);
 					//	m_bgImg
-					$tempScale['m_bgImg'] = $tmpStr . '_bgImg.' . trim($GLOBALS['TYPO3_CONF_VARS']['GFX']['im_mask_temp_ext_noloss']);
+					$tempScale['m_bgImg'] = $tmpStr . '_bgImg.miff';
 					$gifBuilder->imageMagickExec($maskBackgroundImage->getForLocalProcessing(), $tempScale['m_bgImg'], $command);
 					//	m_bottomImg / m_bottomImg_mask
 					if ($maskBottomImage instanceof Resource\FileInterface && $maskBottomImageMask instanceof Resource\FileInterface) {

typo3/sysext/core/Configuration/DefaultConfiguration.php

@@ -46,7 +46,6 @@ return array(
 		'im_imvMaskState' => FALSE,						// Boolean: If set, the 'im_negate_mask' state is inverted. This is very useful with newer versions of IM5 (at least 5.4.3+) where the 'im_version_5' setting will set 'im_negate_mask' which will eventually be wrong... Halleluja for ImageMagick - have I ever regreted using that package...
 		'im_v5effects' => 0,							// <p>Integer (-1, 0, 1)</p><dl><dt>0</dt><dd>disabled</dd><dt>-1</dt><dd>Do not sharpen images by default</dd><dt>1</dt><dd>All; blur and sharpening is allowed in ImageMagick.</dd></dl>
 		'im_mask_temp_ext_gif' => FALSE,				// Boolean: This should be set if ImageMagick is version 5+. This is used in class.tslib_content.php for masking images and the extension png is normally used because it's faster than gif for temporary files. But png seems not to work with some IM 5+ versions, so...
-		'im_mask_temp_ext_noloss' => 'miff',			// String: Loss-less ImageMagick extension to use for mask processing in temporary filenames. Normally 'miff' (ImageMagick's OWN format) will do fine. However at least IM 5.4.9 has proved not to be able to write to its own file format which forced me to add this option. You can try and set this to tif/png/jpg if some masking doesn't work the way it should.
 		'im_noScaleUp' => FALSE,						// Boolean: If set, images are not being scaled up if told so (in t3lib/stdgraphics.php)
 		'im_noFramePrepended' => FALSE,					// Boolean: If set, the [x] frame indicator is NOT prepended to filenames in stdgraphic. Some IM5+ version didn't work at all with the typical [0]-prefix, which allow multipage pdf's and animated gif's to be scaled only for the first frame/page and that seriously cuts down rendering time. Set this flag only if your ImageMagick version cannot find the files. Notice that changing this flag causes temporary filenames to change, thus the server will begin scaling images again which were previously cached.
 		'im_stripProfileCommand' => '+profile \'*\'',	// String: Specify the command to strip the profile information, which can reduce thumbnail size up to 60KB. Command can differ in IM/GM, IM also know the -strip command. See <a href="http://www.imagemagick.org/Usage/thumbnails/#profiles" target="_blank">imagemagick.org</a> for details

typo3/sysext/install/Classes/Controller/StepController.php

@@ -74,6 +74,8 @@ class StepController extends AbstractController {
 		'GFX/im_combine_filename',
 		// #22687
 		'GFX/gdlib_2',
+		// #52012
+		'GFX/im_mask_temp_ext_noloss',
 		// #52010
 		'GFX/im_no_effects',
 		// #18431

typo3/sysext/install/Resources/Public/Images/TestReference/About.txt

@@ -13,7 +13,6 @@ $TYPO3_CONF_VARS['GFX']['im_version_5'] = 'im5';
 $TYPO3_CONF_VARS['GFX']['im_imvMaskState'] = '0';
 $TYPO3_CONF_VARS['GFX']['im_v5effects'] = '1';
 $TYPO3_CONF_VARS['GFX']['gdlib_2'] = 1;
-$TYPO3_CONF_VARS['GFX']['im_mask_temp_ext_noloss'] = 'png';
 
 - PHP / GD configuration:
 GD Support		enabled