[TASK] Upgrade to phpunit 5.2
With minimum php7 and after codeception released a patch level that introduced phpunit 5.x support, we can upgrade our phpunit dev dependency to 5.2 along with a patch level upgrade of vfsStream. This phpunit version is a bit more strict, some unclean tests stumble and need fixes: * $this->setExpectedException() needs a string as second argument, all places with $this->anything() or $this->any() to ignore the actual exception string are now substituted with empty string, the tests rely on the timestamp to specify a specific exception. * $aMock->expects()->method('aMethod') now throws exceptions if a method name is specified that is either not mocked in $this->getMock() or that does not exist in the mocked class. This was previously ignored. This change now catches a lot of code smell in our tests :) Change-Id: I546f8f4b3e05b3d643f4ee6be8e1d4c6e23fe083 Resolves: #75264 Releases: master Reviewed-on: https://review.typo3.org/47388 Reviewed-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
Showing
- composer.json 2 additions, 2 deletionscomposer.json
- composer.lock 180 additions, 40 deletionscomposer.lock
- typo3/sysext/backend/Tests/Unit/Form/FormDataCompilerTest.php 8 additions, 8 deletions...3/sysext/backend/Tests/Unit/Form/FormDataCompilerTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/FlexFormSegmentTest.php 1 addition, 1 deletion...end/Tests/Unit/Form/FormDataGroup/FlexFormSegmentTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/InlineParentRecordTest.php 1 addition, 1 deletion.../Tests/Unit/Form/FormDataGroup/InlineParentRecordTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/OnTheFlyTest.php 2 additions, 2 deletions...xt/backend/Tests/Unit/Form/FormDataGroup/OnTheFlyTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaDatabaseRecordTest.php 1 addition, 1 deletion...d/Tests/Unit/Form/FormDataGroup/TcaDatabaseRecordTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaInputPlaceholderRecordTest.php 1 addition, 1 deletion...Unit/Form/FormDataGroup/TcaInputPlaceholderRecordTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php 5 additions, 5 deletions.../Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php 1 addition, 1 deletion...s/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabasePageLanguageOverlayRowsTest.php 1 addition, 1 deletion.../FormDataProvider/DatabasePageLanguageOverlayRowsTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRecordTypeValueTest.php 5 additions, 5 deletions...nit/Form/FormDataProvider/DatabaseRecordTypeValueTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowInitializeNewTest.php 4 additions, 4 deletions...it/Form/FormDataProvider/DatabaseRowInitializeNewTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseSystemLanguageRowsTest.php 1 addition, 1 deletion.../Form/FormDataProvider/DatabaseSystemLanguageRowsTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUniqueUidNewRowTest.php 1 addition, 1 deletion...nit/Form/FormDataProvider/DatabaseUniqueUidNewRowTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUserPermissionCheckTest.php 9 additions, 9 deletions...Form/FormDataProvider/DatabaseUserPermissionCheckTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/InitializeProcessedTcaTest.php 3 additions, 5 deletions...Unit/Form/FormDataProvider/InitializeProcessedTcaTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php 2 additions, 2 deletions...Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessShowitemTest.php 1 addition, 1 deletion...t/Form/FormDataProvider/TcaColumnsProcessShowitemTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexFetchTest.php 1 addition, 1 deletion...end/Tests/Unit/Form/FormDataProvider/TcaFlexFetchTest.php
Please register or sign in to comment