Skip to content
Snippets Groups Projects
Commit 6c0fe9b0 authored by Thomas Hohn's avatar Thomas Hohn Committed by Christian Kuhn
Browse files

[TASK] Add todo for strictly typing class UnableToLinkException

The constructor of UnableToLinkException should be strictly
typed, since the method getLinkText() is strictly typed.
Also make the variable declaration of $linkText strictly typed.
It will throw an error if $linkText isn't a string.
Added a todo for TYPO3 v13.

Resolves: #100119
Related: #100106
Releases: main
Change-Id: Ifbb9a3f5b4aa1fd1588eb0596731377f41bc5ffd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78072


Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Tested-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
parent eab3ec40
Branches
Tags
No related merge requests found
...@@ -26,6 +26,7 @@ class UnableToLinkException extends Exception ...@@ -26,6 +26,7 @@ class UnableToLinkException extends Exception
{ {
/** /**
* @var string the text which should have gone inside the * @var string the text which should have gone inside the
* @todo Make $linkText strictly typed in TYPO3 v13
*/ */
protected $linkText; protected $linkText;
...@@ -36,6 +37,7 @@ class UnableToLinkException extends Exception ...@@ -36,6 +37,7 @@ class UnableToLinkException extends Exception
* @param int $code [optional] The Exception code. * @param int $code [optional] The Exception code.
* @param \Throwable $previous [optional] The previous throwable used for the exception chaining. * @param \Throwable $previous [optional] The previous throwable used for the exception chaining.
* @param string $linkText [optional] * @param string $linkText [optional]
* @todo Make the signature strictly typed in TYPO3 v13
*/ */
public function __construct($message = '', $code = 0, \Throwable $previous = null, $linkText = '') public function __construct($message = '', $code = 0, \Throwable $previous = null, $linkText = '')
{ {
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment