Skip to content
Snippets Groups Projects
Commit 65fa7b45 authored by Andreas Fernandez's avatar Andreas Fernandez
Browse files

[BUGFIX] Dispatch native `change` event in TBE_EDITOR.fieldChanged()

With #87324 some code of FormEngine was moved into separated modules. In
the very same patch, most of the code was rewritten to use native
JavaScript as much as possible. However, with this change,
`TBE_EDITOR.fieldChanged()` was partially broken as it uses jQuery's
`triggerHandler` method to trigger a specific event. Events that are
registered via jQuery's `on()` method work fine, but the approach is
incompatible with JavaScript's native `addEventListener()` introduced
in the mentioned change.

As a quick fix, `TBE_EDITOR.fieldChanged()` now triggers the same event
for native JavaScript code via `dispatchEvent()`.

Resolves: #88738
Related: #87324
Releases: master
Change-Id: I38fbb97f86f6765a45ad763c27e7afdac5754b1c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61278


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
parent 66e99e14
Branches
Tags
No related merge requests found
......@@ -74,7 +74,8 @@ var TBE_EDITOR = {
// modify the "field has changed" info by adding a class to the container element (based on palette or main field)
var $formField = $('[name="' + el + '"]');
var $humanReadableField = $('[data-formengine-input-name="' + el + '"]');
if (!$formField.is($humanReadableField)) {
if ($humanReadableField.length > 0 && !$formField.is($humanReadableField)) {
$humanReadableField.get(0).dispatchEvent(new Event('change', {bubbles: true, cancelable: true}));
$humanReadableField.triggerHandler('change');
}
// add class to palette field
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment