Skip to content
Snippets Groups Projects
Commit 5acedb08 authored by Benni Mack's avatar Benni Mack
Browse files

[!!!][TASK] Remove cache_imagesizes

This change removes the cache "imagesizes" along
with the public methods within GraphicalFunctions.

The main reason for having cache_imagesizes back in
TYPO3 v4.x was that detecting the image sizes was done
via ImageMagick solely.

Nowadays, the ImageInfo functionality is used,
which uses

- getimagesize()
- exif_read_data()

before falling back to ImageMagick identify.

Most places in TYPO3 Core already use ImageInfo directly
without using the cache.

A image size calculation is nowadays with SSD much faster
than a decade before, whereas a DB cache (by default) for
cache_imagesizes has a much more latency.

As cache_imagesizes is solely used for local files,
remote FAL drivers do not have a problem here as well.

Removed public methods:
- GraphicalFunctions->cacheImageDimensions()
- GraphicalFunctions->getCachedImageDimensions()

The main public method GraphicalFunctions->getImageDimensions()
still continues to exist and work as before.

Resolves: #102009
Releases: main
Change-Id: I6075e796b5e729733bd60eb7d2e005f5f5cc4b33
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81105


Tested-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarcore-ci <typo3@b13.com>
parent 457342db
Branches
Tags
No related merge requests found
Showing
with 125 additions and 167 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment