[TASK] Replace prophecy in EXT:form FormDefinitionArrayConverterTest

Resolves: #98976
Releases: main
Change-Id: Ie7ac39209934349deb9ed6b76123a12cbd4e5ff8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76803


Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>

typo3/sysext/form/Tests/Unit/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php

@@ -17,8 +17,6 @@ declare(strict_types=1);
 
 namespace TYPO3\CMS\Form\Tests\Unit\Mvc\Property\TypeConverter;
 
-use Prophecy\Argument;
-use Prophecy\PhpUnit\ProphecyTrait;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Form\Domain\Configuration\Exception\PropertyException;
 use TYPO3\CMS\Form\Domain\Configuration\FormDefinitionValidationService;
@@ -28,13 +26,8 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
 class FormDefinitionArrayConverterTest extends UnitTestCase
 {
-    use ProphecyTrait;
-
     protected bool $resetSingletonInstances = true;
 
-    /**
-     * Set up
-     */
     public function setUp(): void
     {
         parent::setUp();
@@ -71,10 +64,10 @@ class FormDefinitionArrayConverterTest extends UnitTestCase
              ],
         ];
 
-        $typeConverter = $this->getAccessibleMock(FormDefinitionArrayConverter::class, ['getFormDefinitionValidationService', 'retrieveSessionToken'], [], '', false);
-        $formDefinitionValidationService = $this->prophesize(FormDefinitionValidationService::class);
-        $formDefinitionValidationService->validateFormDefinitionProperties(Argument::cetera())->shouldBeCalled();
-        $formDefinitionValidationService->isPropertyValueEqualToHistoricalValue(Argument::cetera())->willReturn(true);
+        $typeConverter = $this->getAccessibleMock(FormDefinitionArrayConverter::class, ['getFormDefinitionValidationService', 'retrieveSessionToken'], callOriginalConstructor: false);
+        $formDefinitionValidationServiceMock = $this->createMock(FormDefinitionValidationService::class);
+        $formDefinitionValidationServiceMock->expects(self::atLeastOnce())->method('validateFormDefinitionProperties')->with(self::anything());
+        $formDefinitionValidationServiceMock->method('isPropertyValueEqualToHistoricalValue')->with(self::anything())->willReturn(true);
 
         $typeConverter->method(
             'retrieveSessionToken'
@@ -82,7 +75,7 @@ class FormDefinitionArrayConverterTest extends UnitTestCase
 
         $typeConverter->method(
             'getFormDefinitionValidationService'
-        )->willReturn($formDefinitionValidationService->reveal());
+        )->willReturn($formDefinitionValidationServiceMock);
 
         $input = json_encode($data);
         $expected = [