Skip to content
Snippets Groups Projects
Commit 4a6fa2a6 authored by Sascha Löffler's avatar Sascha Löffler Committed by Christian Kuhn
Browse files

[TASK] Make TaskTest notice free

Resolves: #84426
Releases: master
Change-Id: I2de52b5ddaacdfb9f8e29a11009ef7db3d9e1c46
Reviewed-on: https://review.typo3.org/56297


Reviewed-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent e5030d48
Branches
Tags
No related merge requests found
......@@ -178,7 +178,7 @@ class Task extends AbstractTask
if (!empty($this->arguments)) {
$arguments = [];
foreach ($this->arguments as $argumentName => $argumentValue) {
if ($argumentValue != $this->defaults[$argumentName]) {
if (!isset($this->defaults[$argumentName]) || $argumentValue != $this->defaults[$argumentName]) {
$arguments[] = $argumentName . '=' . $argumentValue;
}
}
......
<?php
declare(strict_types = 1);
namespace TYPO3\CMS\Extbase\Tests\Unit\Scheduler;
/*
......@@ -14,16 +15,15 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Scheduler;
* The TYPO3 project - inspiring people to share!
*/
use TYPO3\CMS\Extbase\Scheduler\Task;
use TYPO3\CMS\Extbase\Scheduler\TaskExecutor;
use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
/**
* Test case
*/
class TaskTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
class TaskTest extends UnitTestCase
{
/**
* Subject is not notice free, disable E_NOTICES
*/
protected static $suppressNotices = true;
/**
* @var \TYPO3\CMS\Extbase\Scheduler\Task|\PHPUnit_Framework_MockObject_MockObject|\TYPO3\TestingFramework\Core\AccessibleObjectInterface
*/
......@@ -36,11 +36,11 @@ class TaskTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
protected function setUp()
{
$this->taskExecutor = $this->getMockBuilder(\TYPO3\CMS\Extbase\Scheduler\TaskExecutor::class)
$this->taskExecutor = $this->getMockBuilder(TaskExecutor::class)
->setMethods(['execute'])
->disableOriginalConstructor()
->getMock();
$this->task = $this->getAccessibleMock(\TYPO3\CMS\Extbase\Scheduler\Task::class, ['logException', '__wakeup'], [], '', false);
$this->task = $this->getAccessibleMock(Task::class, ['logException', '__wakeup'], [], '', false);
}
/**
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment