Skip to content
Snippets Groups Projects
Commit 47525f4a authored by Benni Mack's avatar Benni Mack Committed by Andreas Fernandez
Browse files

[BUGFIX] Ensure ZipService sets proper permissions recursively

ZipService->extract was introduced for a security patch set
but the permissions are not set correctly, as fixPermissions
receives a directory with a slash at the end, resulting
in "//" for recursive checks.

This patch fixes the issue.

Resolves: #90417
Relates: #90118
Releases: master, 9.5
Change-Id: Ie56ef6a3781b12c9ac2cf9a859ec226f48691d7f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64267


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarTymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: default avatarDanilo Caccialanza <supercaccia@bluewin.ch>
Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarTymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: default avatarDanilo Caccialanza <supercaccia@bluewin.ch>
Reviewed-by: default avatarGuido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
parent a7cb879b
Branches
Tags
No related merge requests found
...@@ -51,7 +51,7 @@ class ZipService ...@@ -51,7 +51,7 @@ class ZipService
$result = $zip->extractTo($directory); $result = $zip->extractTo($directory);
$zip->close(); $zip->close();
if ($result) { if ($result) {
GeneralUtility::fixPermissions($directory, true); GeneralUtility::fixPermissions(rtrim($directory, '/'), true);
} }
return $result; return $result;
} }
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment