Skip to content
Snippets Groups Projects
Commit 3c6d295a authored by Benjamin Franzke's avatar Benjamin Franzke Committed by Alexander Schnitzler
Browse files

[TASK] Provide dependency injection configuration for extbase DataMapper

The extbase DataMapper was changed to use constructor based
dependency injection with change #87305. The argument $query
(of type QueryInterface) was set to a nullable
and way therefore ignored by the Extbase ObjectManager.

This class is currently only used via the Extbase ObjectManager
in core. It was therefore excluded from the symfony dependency
injection and therefore never fataled during symfony DI
container build.

Symfony DI does – in contrast to extbase DI – inject nullable
constructor arguments.
That means:
Once core or an extension starts to inject this service,
injection will fail, as QueryInterface points to the Query object
which is not autowirable. (see exception below)

Note: While it is not supported that extensions inject
this internal service, we still fix this case, because the
exception is a) hard to debug und b) core may inject it in
future.

The service is also declarted to be a prototype (shared: false) as it may
contain state, as set via `setQuery`.

[1] exception thrown by symfonyduring DI compilation:
    Symfony\Component\DependencyInjection\Exception\RuntimeException:
    Cannot autowire service "TYPO3\CMS\Extbase\Persistence\Generic\Query":
    argument "$type" of method "__construct()" has no type-hint,
    you should configure its value explicitly.

Releases: master
Resolves: #91200
Related: #87305
Change-Id: I58b1cff94136a4170fb7e6712470069a141940b7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64319


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarSebastian Fischer <typo3@evoweb.de>
Tested-by: default avatarAlexander Schnitzler <git@alexanderschnitzler.de>
Reviewed-by: default avatarSebastian Fischer <typo3@evoweb.de>
Reviewed-by: default avatarAlexander Schnitzler <git@alexanderschnitzler.de>
parent e67853b5
Branches
Tags
No related merge requests found
......@@ -35,6 +35,11 @@ services:
TYPO3\CMS\Extbase\Persistence\Generic\QueryResult: ~
TYPO3\CMS\Extbase\Persistence\Generic\Typo3QuerySettings: ~
TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMapper:
shared: false
arguments:
$query: null
cache.extbase:
class: TYPO3\CMS\Core\Cache\Frontend\FrontendInterface
factory: ['@TYPO3\CMS\Core\Cache\CacheManager', 'getCache']
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment