[TASK] Clean up unit tests on Windows
At the moment a lot of tests are skipped on Windows environments. The main reasons are permissions, symlinks and shell exec commands. As symlinks are now working on Windows (if the user / group is allowed to create them) there is no reason to skip those tests. As you can only create valid symlinks on Windows (the target is checked for existence) the tests needed to be adjusted to take that into account. Additionally some of the other tests don't need to be skipped either, as they mock all system specific calls (e.g. AbstractNodeTests). For the other tests the message on skipping was updated to contain more information as to what causes them to be irrelevant on Windows. Resolves: #75388 Releases: master Change-Id: I86c6d9b0cec34a94d1185f46e2023af811b16107 Reviewed-on: https://review.typo3.org/47502 Reviewed-by:Susanne Moog <typo3@susannemoog.de> Tested-by:
Susanne Moog <typo3@susannemoog.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/core/Classes/Utility/GeneralUtility.php 4 additions, 0 deletionstypo3/sysext/core/Classes/Utility/GeneralUtility.php
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php 2 additions, 4 deletions...ore/Tests/Unit/Configuration/ConfigurationManagerTest.php
- typo3/sysext/core/Tests/Unit/Core/SystemEnvironmentBuilderTest.php 0 additions, 6 deletions...ext/core/Tests/Unit/Core/SystemEnvironmentBuilderTest.php
- typo3/sysext/core/Tests/Unit/Locking/SimpleLockStrategyTest.php 0 additions, 3 deletions...sysext/core/Tests/Unit/Locking/SimpleLockStrategyTest.php
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php 25 additions, 30 deletionstypo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
- typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php 2 additions, 18 deletions...t/install/Tests/Unit/FolderStructure/AbstractNodeTest.php
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php 0 additions, 9 deletions.../install/Tests/Unit/FolderStructure/DirectoryNodeTest.php
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php 0 additions, 9 deletions...ysext/install/Tests/Unit/FolderStructure/FileNodeTest.php
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php 10 additions, 16 deletions...ysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php
- typo3/sysext/rsaauth/Tests/Unit/Backend/CommandLineBackendTest.php 1 addition, 1 deletion...ext/rsaauth/Tests/Unit/Backend/CommandLineBackendTest.php
Please register or sign in to comment