Skip to content
Snippets Groups Projects
Commit 35f272f2 authored by Nikita Hovratov's avatar Nikita Hovratov Committed by Benni Mack
Browse files

[BUGFIX] Remove always true part of if condition

This patch fixes several small bugs regarding DataHandler range
validation:

1. The strict comparison of the value against the default value might
compare floats with integer values. This causes the condition to be
always true. Besides of that, it's not smart to skip range validation
if the value equals the default value as the default value itself can
be out of range due to user error.

2. The TCA option "checkbox" for fields of type "input" is not used
anymore since TYPO3 4.5. This can be safely removed as the todo stated.

3. The tests for range validation with values evaluated as type double
used an incorrect eval value: "double". The correct value is "double2".
Tests are fixed according to that.

Resolves: #94527
Releases: master, 10.4
Change-Id: I9cdf836272b4cce64f9e35a09107499d25fc955f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69804


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
parent df82c2b3
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment