Skip to content
Snippets Groups Projects
Commit 318f6ceb authored by Benjamin Franzke's avatar Benjamin Franzke
Browse files

[TASK] Apply some runTests.sh cleanups

 * Always clean-up containers when Control-C is pressed
 * Enforce removing networks even if some containers have not been
   fully stopped (does not work with older docker versions, therefore
   only enabled for podman)
 * Bail out if `waitFor` failed instead of resuming with subsequent
   commands
 * Avoid waiting unnecessarily for VNC-web port 7900 in headless mode
 * Do not derive `--pull=never` from the `$CI` environment variable, as
   `$CI` is set both in gitlab [1] and github [2] actions.
   runTests.sh might be used in github actions, therefore this flag is
   moved into our gitlab-ci specific configuration.
 * Fix broken `-b podman -s acceptance -d sqlite` UID mapping and sqlite
   mount
   Error was: `unknown mount option "uid=1000": invalid mount option`
   The sqlite tmpfs is removed, as the sqlite tmpfs can not be shared
   between the PHP development server and codecept (which bootstraps
   the database in `bin/codecept` in classic-mode)
 * Avoid `--add-host` for podman for compat with github ubuntu-latest
   podman version
 * Fix typos

[1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html
[2] https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables

Resolves: #103420
Releases: main, 12.4, 11.5
Change-Id: Ie8fcdc5ebc5ba651242bb54faffdfd8de0dc6026
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83514


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarBenjamin Franzke <ben@bnf.dev>
Reviewed-by: default avatarBenjamin Franzke <ben@bnf.dev>
parent b67a88f6
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment