[BUGFIX] Submitted form data has precedence over value argument
This adjusts the behavior of all Form ViewHelpers so that any submitted value is redisplayed even if a "value" argument has been specified. The issue with this, however, was that upon re-display of the form due to property-mapping or validation errors the value argument had precedence over the previously submitted value. This is a breaking change if you expect the previous behavior of form ViewHelpers always being pre-populated with the specified value attribute / bound object property even when re-displaying the form upon validation errors. Besides this change deprecates ``AbstractFormFieldViewHelper::getValue()``. If you call that method in your custom ViewHelpers you should use ``AbstractFormFieldViewHelper::getValueAttribute()`` instead and call ``AbstractFormFieldViewHelper::addAdditionalIdentityPropertiesIfNeeded()`` explicitly if the ViewHelper might be bound to (sub)entities. The default usage of getValueAttribute() not respect the submitted form data, because not every viewhelper need this feature. But you can enable the usage of the form data by setting the AbstractFormFieldViewHelper::respectSubmittedDataValue to TRUE. Change-Id: I05d9996df0a5594390ff7a005bbee7f2ceeb06bc Resolves: #66588 Related: #34186 Releases: master Reviewed-on: http://review.typo3.org/42298 Reviewed-by:Sascha Wilking <sascha.wilking@hmmh.de> Tested-by:
Sascha Wilking <sascha.wilking@hmmh.de> Reviewed-by:
Susanne Moog <typo3@susannemoog.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
Showing
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-66588-POSTDataInSelectviewhelperShouldHaveHigherPriorityThanValueValue.rst 36 additions, 0 deletions...electviewhelperShouldHaveHigherPriorityThanValueValue.rst
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php 138 additions, 16 deletions.../Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php 28 additions, 8 deletions...ysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php 31 additions, 23 deletions...ext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/HiddenViewHelper.php 1 addition, 1 deletion...ysext/fluid/Classes/ViewHelpers/Form/HiddenViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php 13 additions, 4 deletions...ext/fluid/Classes/ViewHelpers/Form/PasswordViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php 19 additions, 10 deletions...sysext/fluid/Classes/ViewHelpers/Form/RadioViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php 3 additions, 1 deletion...ysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php 5 additions, 3 deletions...ysext/fluid/Classes/ViewHelpers/Form/SubmitViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php 3 additions, 1 deletion...ext/fluid/Classes/ViewHelpers/Form/TextareaViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php 3 additions, 1 deletion...xt/fluid/Classes/ViewHelpers/Form/TextfieldViewHelper.php
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormFieldViewHelperTest.php 257 additions, 88 deletions...Unit/ViewHelpers/Form/AbstractFormFieldViewHelperTest.php
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/CheckboxViewHelperTest.php 10 additions, 10 deletions...id/Tests/Unit/ViewHelpers/Form/CheckboxViewHelperTest.php
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/HiddenViewHelperTest.php 4 additions, 2 deletions...luid/Tests/Unit/ViewHelpers/Form/HiddenViewHelperTest.php
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/RadioViewHelperTest.php 9 additions, 7 deletions...fluid/Tests/Unit/ViewHelpers/Form/RadioViewHelperTest.php
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.php 3 additions, 3 deletions...luid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.php
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php 4 additions, 1 deletion...ysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php
Please register or sign in to comment