[BUGFIX] Do not try to fetch additionalFields for invalid tasks
A task may be invalid when editing so there is no instance of AbstractTask in $task. With this patch the SchedulerModuleController no longer tries to add the additionalFields for that as the AdditionalFieldProviders expect a valid task object when being called on edit. Additionally some cleanup in the PHPDoc of AdditionalFieldProviders is made to make it clear the given task may be NULL on create. Resolves: #79141 Releases: master, 8.7 Change-Id: Ia7cf8173e65cfdede89a776cff7615678e4ffb21 Reviewed-on: https://review.typo3.org/55122 Tested-by:TYPO3com <no-reply@typo3.com> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Reviewed-by:
Benjamin Kluge <b.kluge@neusta.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/extbase/Classes/Scheduler/FieldProvider.php 9 additions, 7 deletionstypo3/sysext/extbase/Classes/Scheduler/FieldProvider.php
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php 1 addition, 1 deletion...tor/Classes/Task/ValidatorTaskAdditionalFieldProvider.php
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTaskNotificationEmailField.php 5 additions, 4 deletions...ses/Task/SystemStatusUpdateTaskNotificationEmailField.php
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php 5 additions, 6 deletions...cheduler/Classes/Controller/SchedulerModuleController.php
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php 1 addition, 1 deletion...Task/ExecuteSchedulableCommandAdditionalFieldProvider.php
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php 6 additions, 6 deletions...ses/Task/FileStorageExtractionAdditionalFieldProvider.php
Please register or sign in to comment