Skip to content
Snippets Groups Projects
Commit 1d71cf73 authored by Łukasz Uznański's avatar Łukasz Uznański Committed by Christian Kuhn
Browse files

[TASK] Make AreaTest notice free

Resolves: 84436
Releases: master
Change-Id: Ie882198724aaa3d77f695e036599dee3a1211938
Reviewed-on: https://review.typo3.org/56308


Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent 4a6fa2a6
No related merge requests found
...@@ -23,15 +23,10 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase; ...@@ -23,15 +23,10 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
class AreaTest extends UnitTestCase class AreaTest extends UnitTestCase
{ {
/**
* Subject is not notice free, disable E_NOTICES
*/
protected static $suppressNotices = true;
/** /**
* @test * @test
*/ */
public function makeRelativeToFileReducesSizes() public function makeRelativeToFileReducesSizes(): void
{ {
$imageArea = new Area(50.0, 50.0, 100.0, 100.0); $imageArea = new Area(50.0, 50.0, 100.0, 100.0);
$imageFixture = new File( $imageFixture = new File(
...@@ -49,7 +44,7 @@ class AreaTest extends UnitTestCase ...@@ -49,7 +44,7 @@ class AreaTest extends UnitTestCase
$this->assertSame($expectedResult, $relativeArea->asArray()); $this->assertSame($expectedResult, $relativeArea->asArray());
} }
public function applyRatioRestrictsAreaToRespectRatioDataProvider() public function applyRatioRestrictsAreaToRespectRatioDataProvider(): array
{ {
return [ return [
[ [
...@@ -77,7 +72,7 @@ class AreaTest extends UnitTestCase ...@@ -77,7 +72,7 @@ class AreaTest extends UnitTestCase
* @test * @test
* @dataProvider applyRatioRestrictsAreaToRespectRatioDataProvider * @dataProvider applyRatioRestrictsAreaToRespectRatioDataProvider
*/ */
public function applyRatioRestrictsAreaToRespectRatio(array $areaSize, $ratio) public function applyRatioRestrictsAreaToRespectRatio(array $areaSize, $ratio): void
{ {
$area = new Area(...$areaSize); $area = new Area(...$areaSize);
$ratioFixture = new Ratio('dummy', 'dummy', $ratio); $ratioFixture = new Ratio('dummy', 'dummy', $ratio);
...@@ -88,7 +83,7 @@ class AreaTest extends UnitTestCase ...@@ -88,7 +83,7 @@ class AreaTest extends UnitTestCase
/** /**
* @test * @test
*/ */
public function applyRatioDoesNothingForFreeRatio() public function applyRatioDoesNothingForFreeRatio(): void
{ {
$area = new Area(0.1, 0.1, 0.2, 0.4); $area = new Area(0.1, 0.1, 0.2, 0.4);
$ratioFixture = new Ratio('dummy', 'dummy', 0.0); $ratioFixture = new Ratio('dummy', 'dummy', 0.0);
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment