[TASK] Streamline services in reports module

* Use current table implementation
* Use lead class for 1st paragraph
* Use h3 for headlines of both check

Resolves: #61453
ReleaseS: 6.3
Change-Id: Ie3e00423949acfee5f8ccadb7f4e46b44660baf2
Reviewed-on: http://review.typo3.org/32652


Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>

typo3/sysext/reports/Resources/Public/styles.css

@@ -51,3 +51,12 @@ body#ext-reports-mod-index-php {
 	float: left;
 }
 
+.tx_sv_reportlist .typo3-message {
+	padding: 12px !important;
+	padding-left: 36px !important;
+	border: none;
+}
+
+.tx_sv_reportlist p.service-header {
+	margin-top: 0px;
+}
\ No newline at end of file

typo3/sysext/sv/Classes/Report/ServicesListReport.php

@@ -13,6 +13,7 @@ namespace TYPO3\CMS\Sv\Report;
  *
  * The TYPO3 project - inspiring people to share!
  */
+
 /**
  * This class provides a report displaying a list of all installed services
  * Code inspired by EXT:dam/lib/class.tx_dam_svlist.php by René Fritz
@@ -57,7 +58,7 @@ class ServicesListReport implements \TYPO3\CMS\Reports\ReportInterface {
 	 * @return string The help content for this module.
 	 */
 	protected function renderHelp() {
-		$help = '<p class="help">' . $GLOBALS['LANG']->getLL('report_explanation') . '</p>';
+		$help = '<p class="lead">' . $GLOBALS['LANG']->getLL('report_explanation') . '</p>';
 		$help .= '<p class="help">' . $GLOBALS['LANG']->getLL('externals_explanation') . '</p><br />';
 		return $help;
 	}
@@ -84,10 +85,10 @@ class ServicesListReport implements \TYPO3\CMS\Reports\ReportInterface {
 	 * @return string Service list as HTML for one service type
 	 */
 	protected function renderServiceTypeList($serviceType, $services) {
-		$header = '<h4>' . sprintf($GLOBALS['LANG']->getLL('service_type'), $serviceType) . '</h4>';
+		$header = '<h3 class="divider">' . sprintf($GLOBALS['LANG']->getLL('service_type'), $serviceType) . '</h3>';
 		$serviceList = '
-		<table cellspacing="1" cellpadding="2" border="0" class="tx_sv_reportlist services">
-			<tr class="t3-row-header">
+		<table class="t3-table tx_sv_reportlist">
+			<thead><tr class="t3-row-header">
 				<td style="width: 35%">' . $GLOBALS['LANG']->getLL('service') . '</td>
 				<td>' . $GLOBALS['LANG']->getLL('priority') . '</td>
 				<td>' . $GLOBALS['LANG']->getLL('quality') . '</td>
@@ -95,11 +96,12 @@ class ServicesListReport implements \TYPO3\CMS\Reports\ReportInterface {
 				<td>' . $GLOBALS['LANG']->getLL('os') . '</td>
 				<td>' . $GLOBALS['LANG']->getLL('externals') . '</td>
 				<td>' . $GLOBALS['LANG']->getLL('available') . '</td>
-			</tr>';
+			</tr></thead><tbody>';
 		foreach ($services as $serviceKey => $serviceInformation) {
 			$serviceList .= $this->renderServiceRow($serviceKey, $serviceInformation);
 		}
 		$serviceList .= '
+		</tbody>
 		</table>
 		';
 		return $header . $serviceList;
@@ -154,12 +156,12 @@ class ServicesListReport implements \TYPO3\CMS\Reports\ReportInterface {
 	 */
 	protected function renderExecutablesSearchPathList() {
 		$searchPaths = \TYPO3\CMS\Core\Utility\CommandUtility::getPaths(TRUE);
-		$content = '<br /><h3 class="divider">' . $GLOBALS['LANG']->getLL('search_paths') . '</h3>';
+		$content = '<h3 class="divider">' . $GLOBALS['LANG']->getLL('search_paths') . '</h3>';
 		if (count($searchPaths) == 0) {
 			$content .= '<p>' . $GLOBALS['LANG']->getLL('no_search_paths') . '</p>';
 		} else {
 			$content .= '
-			<table cellspacing="1" cellpadding="2" border="0" class="tx_sv_reportlist paths">
+			<table class="t3-table tx_sv_reportlist">
 				<thead>
 					<tr class="t3-row-header">
 						<td>' . $GLOBALS['LANG']->getLL('path') . '</td>