Skip to content
Snippets Groups Projects
Commit 164b1fba authored by Ralf Zimmermann's avatar Ralf Zimmermann Committed by Christian Kuhn
Browse files

[BUGFIX] EXT:form - fix radio button html markup 

Make the radio button html markup closer to
http://getbootstrap.com/css/#checkboxes-and-radios

- remove the "for" attribute from the container label tag
- add the "radio" class to the elements div wrapper
- remove the class attribute from the elements label tag

Resolves: #81715
Releases: master
Change-Id: Ic4be5b51f38fb2313e230bfaf0f85ec7fe8431c9
Reviewed-on: https://review.typo3.org/53364


Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarMathias Brodala <mbrodala@pagemachine.de>
Tested-by: default avatarMathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: default avatarJoerg Boesche <typo3@joergboesche.de>
Reviewed-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent d9b2c19d
No related merge requests found
Hide whitespace changes
Inline Side-by-side
typo3/sysext/form/Resources/Private/Frontend/Partials/RadioButton.html
+ 20
− 17
View file @ 164b1fba
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<formvh:renderRenderable renderable="{element}">
<f:render partial="Field/Field" arguments="{element: element}" contentAs="elementContent">
<div id="{element.uniqueIdentifier}" class="inputs-list">
<div class="form-group">
<f:for each="{element.properties.options}" as="label" key="value">
<div class="form-check">
<label class="form-check-label">
<f:form.radio
property="{element.identifier}"
class="{element.properties.elementClassAttribute} form-check-input"
value="{value}"
errorClass="{element.properties.elementErrorClassAttribute}"
additionalAttributes="{formvh:translateElementProperty(element: element, property: 'fluidAdditionalAttributes')}"
/>
<span>{formvh:translateElementProperty(element: element, property: 'options.{value}')}</span>
</label>
</div>
</f:for>
<f:render partial="Field/Field" arguments="{element: element, doNotShowLabel: 1}" contentAs="elementContent">
<label class="control-label">{formvh:translateElementProperty(element: element, property: 'label')}<f:if condition="{element.required}"><f:render partial="Field/Required" /></f:if></label>
<div class="{element.properties.containerClassAttribute}">
<div id="{element.uniqueIdentifier}" class="inputs-list">
<div class="form-group">
<f:for each="{element.properties.options}" as="label" key="value">
<div class="radio">
<label>
<f:form.radio
property="{element.identifier}"
class="{element.properties.elementClassAttribute} form-check-input"
value="{value}"
errorClass="{element.properties.elementErrorClassAttribute}"
additionalAttributes="{formvh:translateElementProperty(element: element, property: 'fluidAdditionalAttributes')}"
/>
<span>{formvh:translateElementProperty(element: element, property: 'options.{value}')}</span>
</label>
</div>
</f:for>
</div>
</div>
</div>
</f:render>
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment