[!!!][TASK] FAL: Decouple logic of ResourceFactory into StorageRepository
The "ResourceFactory" class was introduced as a "god class" to build any File/Folder object (from a string, DB row or integer), but is also there for building sys_file_storage (ResourceStorage) objects, so it is mixing a lot of concerns (also driver setup). However, all creation of ResourceStorage objects should be moved into the StorageRepository (which already exists), thus reducing the dependencies towards ResourceFactory. This makes it much easier to not juggle with storage UIDs anymore but actually work with storage objects throughout the internal FAL API. The StorageRepository is not extending from the AbstractRepository anymore, which is breaking. Resolves: #92289 Releases: master Change-Id: Ib367164535550e280a6907f4d4473aa0417c3813 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65184 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Helmut Hummel <typo3@helhum.io>
Showing
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php 2 additions, 2 deletions...lasses/Form/Element/UserSysFileStorageIsPublicElement.php
- typo3/sysext/core/Classes/Resource/File.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Resource/File.php
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php 16 additions, 41 deletions...ysext/core/Classes/Resource/Index/FileIndexRepository.php
- typo3/sysext/core/Classes/Resource/Index/Indexer.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Resource/Index/Indexer.php
- typo3/sysext/core/Classes/Resource/ProcessedFile.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Resource/ProcessedFile.php
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php 0 additions, 1 deletion.../sysext/core/Classes/Resource/ProcessedFileRepository.php
- typo3/sysext/core/Classes/Resource/ResourceFactory.php 32 additions, 200 deletionstypo3/sysext/core/Classes/Resource/ResourceFactory.php
- typo3/sysext/core/Classes/Resource/ResourceStorage.php 57 additions, 13 deletionstypo3/sysext/core/Classes/Resource/ResourceStorage.php
- typo3/sysext/core/Classes/Resource/StorageRepository.php 229 additions, 45 deletionstypo3/sysext/core/Classes/Resource/StorageRepository.php
- typo3/sysext/core/Classes/ServiceProvider.php 5 additions, 2 deletionstypo3/sysext/core/Classes/ServiceProvider.php
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php 0 additions, 2 deletions.../sysext/core/Classes/Utility/File/ExtendedFileUtility.php
- typo3/sysext/core/Documentation/Changelog/master/Breaking-92289-DecoupleLogicOfResourceFactoryIntoStorageRepository.rst 64 additions, 0 deletions...9-DecoupleLogicOfResourceFactoryIntoStorageRepository.rst
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php 9 additions, 9 deletions...xt/core/Tests/Functional/Resource/ResourceStorageTest.php
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php 5 additions, 5 deletionstypo3/sysext/core/Tests/Unit/Resource/FileTest.php
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php 5 additions, 99 deletions...3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php 3 additions, 4 deletions...3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php
- typo3/sysext/core/Tests/Unit/Resource/StorageRepositoryTest.php 127 additions, 0 deletions...sysext/core/Tests/Unit/Resource/StorageRepositoryTest.php
- typo3/sysext/filelist/Classes/Controller/FileListController.php 3 additions, 4 deletions...sysext/filelist/Classes/Controller/FileListController.php
- typo3/sysext/form/Tests/Functional/Hooks/FormFileExtensionUpdateTest.php 2 additions, 2 deletions...rm/Tests/Functional/Hooks/FormFileExtensionUpdateTest.php
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php 2 additions, 1 deletion...sext/frontend/Tests/Functional/Imaging/GifBuilderTest.php
Please register or sign in to comment