Skip to content
Snippets Groups Projects
Commit 0863b02f authored by Helmut Hummel's avatar Helmut Hummel Committed by Wouter Wolters
Browse files

[CLEANUP] Simplify PackageMangerTest

* Remove not needed initialization
* Remove not needed mock
* Fix name of a method that must be mocked

Resolves: #70778
Releases: master
Change-Id: I579feae7fedde190980758563c87116e695efd92
Reviewed-on: http://review.typo3.org/44093


Reviewed-by: default avatarMarkus Klein <markus.klein@typo3.org>
Tested-by: default avatarMarkus Klein <markus.klein@typo3.org>
Reviewed-by: default avatarHelmut Hummel <helmut.hummel@typo3.org>
Tested-by: default avatarHelmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
Tested-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
parent 59b46961
No related merge requests found
......@@ -38,10 +38,6 @@ class PackageManagerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
{
vfsStream::setup('Test');
/** @var Bootstrap|\PHPUnit_Framework_MockObject_MockObject $mockBootstrap */
$mockBootstrap = $this->getMock(Bootstrap::class, array(), array(), '', false);
$mockBootstrap->method('usesComposerClassLoading')->will($this->returnValue(FALSE));
/** @var PhpFrontend|\PHPUnit_Framework_MockObject_MockObject $mockCache */
$mockCache = $this->getMock(PhpFrontend::class, array('has', 'set', 'getBackend'), array(), '', false);
$mockCacheBackend = $this->getMock(SimpleFileBackend::class, array('has', 'set', 'getBackend'), array(), '', false);
......@@ -49,7 +45,7 @@ class PackageManagerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
$mockCache->expects($this->any())->method('set')->will($this->returnValue(true));
$mockCache->expects($this->any())->method('getBackend')->will($this->returnValue($mockCacheBackend));
$mockCacheBackend->expects($this->any())->method('getCacheDirectory')->will($this->returnValue('vfs://Test/Cache'));
$this->packageManager = $this->getAccessibleMock(PackageManager::class, array('sortAndSavePackageStates', 'sortAvailablePackagesByDependencies', 'registerAutoloadInformationInClassLoader'));
$this->packageManager = $this->getAccessibleMock(PackageManager::class, array('sortAndSavePackageStates', 'sortAvailablePackagesByDependencies', 'registerTransientClassLoadingInformationForPackage'));
mkdir('vfs://Test/Packages/Application', 0700, true);
mkdir('vfs://Test/Configuration');
......@@ -63,7 +59,6 @@ class PackageManagerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
$this->inject($this->packageManager, 'composerNameToPackageKeyMap', $composerNameToPackageKeyMap);
$this->packageManager->_set('packagesBasePath', 'vfs://Test/Packages/');
$this->packageManager->_set('packageStatesPathAndFilename', 'vfs://Test/Configuration/PackageStates.php');
$this->packageManager->initialize($mockBootstrap);
}
/**
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment