- Jun 09, 2018
-
-
Frank Naegler authored
The new IpAnonymizationAdditionalFieldProvider introduced the same JavaScript variable which breaks the garbage collection task. The JavaScript initialization has been removed and the field provider simplified. Resolves: #85068 Releases: master, 8.7, 7.6 Change-Id: Ibb307ee37d6fea33a721373bdc50bbbd3fee1453 Reviewed-on: https://review.typo3.org/57136 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Anja Leichsenring authored
New folder and includes to render the changelog for the upcomming version. Change-Id: I0440dcfdaf5541da5e8dbe8b8b681a477951fc14 Resolves: #85202 Releases: master Reviewed-on: https://review.typo3.org/57152 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
The new SEO extension handles opengraph and twitter (seo-relevant), thus do not need to stay in EXT:core, as they are only for sites which need SEO relevant information to be processed. Resolves: #85201 Releases: master Change-Id: Ib0bf503bb939b47747dc32209f78f8e7ce8622c1 Reviewed-on: https://review.typo3.org/57162 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Jan Helke authored
Releases: master Resolves: #85088 Change-Id: Ibd443902f6c89e16946d3d8d2cc39a8e2091054e Reviewed-on: https://review.typo3.org/57059 Reviewed-by:
-
Jan Helke authored
Releases: master Resolves: #84722 Change-Id: I0edb98c7713f5c6520cbbc33e3f85ab1b3f4946f Reviewed-on: https://review.typo3.org/56659 Reviewed-by:
-
Susanne Moog authored
The admin panel initialization is done via middleware before the TypoScript is fully initialized, therefor it cannot have dependencies to parsed TypoScript (and it cannot be initialized at a later state because of cross-dependencies with TSFE). Before #85104 the checks did not include TypoScript - that state has been restored and the dependency has been removed. Resolves: #85193 Releases: master Change-Id: Ic576b02a68ddc20f52b4b1647b0e38c51e1b7df8 Reviewed-on: https://review.typo3.org/57147 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Alexander Stehlik authored
The tests demonstrate the issue described in the ticket is not present anymore. Resolves: #77338 Releases: master Change-Id: I7002b9754f556f23850fda5026861c742f70bcdc Reviewed-on: https://review.typo3.org/49307 Reviewed-by:
-
Jan Helke authored
Releases: master Resolves: #84724 Change-Id: I92a7ccbc88463d3fb3925185247331acf2977e40 Reviewed-on: https://review.typo3.org/56663 Reviewed-by:
-
Jan Helke authored
Releases: master Resolves: #85094 Change-Id: I7fe8e2dd15fa797eef9b153bf2935187181149ae Reviewed-on: https://review.typo3.org/57065 Tested-by:
-
Jan Helke authored
Releases: master Resolves: #84816 Change-Id: I3f0bb5ab96743762977177cad1e6f125b9f23c73 Reviewed-on: https://review.typo3.org/56759 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Jan Helke authored
Releases: master Resolves: #84808 Change-Id: Ia520395c0d4cb3a8efd6529a23a0f65d1fa9247a Reviewed-on: https://review.typo3.org/56751 Tested-by:
-
Jan Helke authored
Releases: master Resolves: #85098 Change-Id: Id2b5c7efbf2672b4731a9bd4b238a0f4be25cd5c Reviewed-on: https://review.typo3.org/57069 Tested-by:
-
Jan Helke authored
Releases: master Resolves: #85095 Change-Id: Iacfffe50c29a47c197c9887610bc0874007f7eec Reviewed-on: https://review.typo3.org/57066 Tested-by:
-
Tymoteusz Motylewski authored
Releases: master Resolves: #84721 Change-Id: I4aca40a0225a84a5af7925b34fc578f28d78b9bc Reviewed-on: https://review.typo3.org/56655 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
-
Benni Mack authored
Both the MetaTagManagerRegistry and the MetaTagManager are singletons via TYPO3's SingletonInterface, thus, there is no need for having a getInstance() within the API itself, nor in any abstract / generic base classes. Resolves: #85197 Releases: master Change-Id: I9aa925a1646a4482313dd740ecc3ae45780c9432 Reviewed-on: https://review.typo3.org/57157 Reviewed-by:
-
Benni Mack authored
The deprecation log file that was used prior to v9.0, was previously stored in typo3conf/deprecation_* which is still used for extensions still using the old API, is now put into var/log/ where all other log files reside. For installations using the environment concept with "$_ENV['TYPO3_PATH_APP']" - e.g. all installations in composer mode - the file is now created at that place, for installations having everything in the public web root, the file is now in "typo3temp/var/log/deprecation_...log". Resolves: #85198 Releases: master Change-Id: I0fc23d9fec6cfa45241c041f64333deb90d44950 Reviewed-on: https://review.typo3.org/57160 Tested-by:
-
Benni Mack authored
This fixes a functional test in EXT:workspaces, allowing for getting rid of an extra check in the frontend request workflow. Resolves: #85199 Releases: master Change-Id: I642fca3a2873f0fe758164fca3f9261480dbc4da Reviewed-on: https://review.typo3.org/57074 Tested-by:
-
Frank Naegler authored
This patch prevent putting invalid data into localStorage in the rare case that the AJAX call does not provide icon markup. Resolves: #85184 Releases: master Change-Id: Icddd88232bf9ac5f77e08ed7fbac475af8b469eb Reviewed-on: https://review.typo3.org/57146 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
The new functionality introduced in #85160 adds TCA control database fields dynamically. However, newly created extensions add these fields (except "uid" which is a primary column) at the end after the content-related fields. The patch re-orders the columns to be added to move them to the very beginning. Resolves: #85195 Related: #85160 Releases: master Change-Id: Ibcf77ae3fea41f067dca0f247bef50d00bdd014f Reviewed-on: https://review.typo3.org/57155 Tested-by:
-
Richard Haeser authored
Move the new SEO fields to EXT:seo and prepare the extension for some basic SEO features. Resolves: #85194 Releases: master Change-Id: I6ec087928080e217ce1824b2e9ad5cf0ca0606c8 Reviewed-on: https://review.typo3.org/57148 Tested-by:
-
Christian Kuhn authored
TYPO3\TestingFramework\Core\FileStreamWrapper belongs to the testing-framework package. The unit test case has been moved to it an can be removed from core. Resolves: #85192 Related: #85096 Releases: master Change-Id: I4d83f92275e34fdad3eac2550db4d3895b141f36 Reviewed-on: https://review.typo3.org/57154 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Christian Kuhn authored
The backend route dispatcher with its different controller incarnations benefits from a basic code coverage. Resolves: #85191 Related: #84196 Releases: master Change-Id: I0ff1efae64c41e7fbeba8fb3569c5601cb005669 Reviewed-on: https://review.typo3.org/56095 Tested-by:
-
- Jun 08, 2018
-
-
Mathias Brodala authored
Resolves: #85119 Releases: master, 8.7 Change-Id: If9c00379c1ac671bd6bb622ace47864866c34446 Reviewed-on: https://review.typo3.org/57091 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Christian Kuhn authored
With an upcoming feature to run TYPO3 on sqlite, the database may end up within Web folder depending on system setup. It may later come with additional checks to prevent a direct database download, but it's a good step to deny web access to .sqlite files via default .htaccess already. Resolves: #85188 Releases: master Change-Id: Id382082f13fbce750b7cb3db98ddb1bc41b10f1e Reviewed-on: https://review.typo3.org/57150 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Christian Kuhn authored
typo3/testing-framework 3.7.0 supports sqlite db platform for functional tests. The patch updates the dependency and adds sqlite functional tests in bamboo pre-merge and nightly. composer update typo3/testing-framework typo3DatabaseDriver=pdo_sqlite bin/phpunit -c \ vendor/typo3/testing-framework/Resources/Core/Build/FunctionalTests.xml There are some know issues already, especially the database schema analyzer of the install tool behaves weird. However, this patch is a first step towards sqlite support in the core. Change-Id: I8e8474dabdf4015a32d3c938adc576fba9b5a5bd Resolves: #85187 Releases: master Reviewed-on: https://review.typo3.org/57137 Tested-by:
-
Christian Kuhn authored
Depending on DB platform, empty LOB fields can be returned as NULL value (sqlite) or as empty string (mysql, our postgres setup, mssql). The patch adapts a minor detail in DataHandler since isset(null) is false, but isset('') is true, it uses an array_key_exists() instead for diff check on transOrigDiffSourceField / l10n_diffsource field to align these two possible different db return values. Resolves: #85186 Releases: master Change-Id: I56c87fa519a0c787515eff403d48ac84e513300d Reviewed-on: https://review.typo3.org/57149 Reviewed-by:Daniel Siepmann <daniel.siepmann@typo3.org> Tested-by:
-
Ralf Zimmermann authored
Move the property merge behavior from setOptions() into the related methods (setRenderingOption(), setProperty(), setDefaultValue()). Releases: master Resolves: #85072 Change-Id: I1c002aeb8d889af68d6147d5c588709cd89ebf3c Reviewed-on: https://review.typo3.org/57045 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Christian Kuhn authored
typo3/cms-styleguide has accidently been made a require instead of a require-dev dependency in composer.json composer require --dev typo3/cms-styleguide ^9.1 Resolves: #85181 Related: #85180 Releases: master Change-Id: Id109894e862ce5ac55a5533eccb8e25a9d8a6049 Reviewed-on: https://review.typo3.org/57145 Tested-by:
-
Christian Kuhn authored
Brings a set of new adaptions to new core functionality. Uses new core feature 'auto-create db fields' to reduce ext_tables.sql. composer require typo3/cms-styleguide ^9.1 Change-Id: I386eec9da50bd3ce7eb5ebb9af8957d3b1c8d9ac Resolves: #85180 Releases: master Reviewed-on: https://review.typo3.org/57144 Tested-by:
-
- Jun 07, 2018
-
-
Christian Kuhn authored
Use a dummy extension and .csv imports from the functional test framework instead of creating tables and records on the fly. Resolves: #85179 Releases: master Change-Id: Ia8f077984e588a2bb142a0e516aad198f914bec9 Reviewed-on: https://review.typo3.org/57143 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Frank Naegler authored
With #85016 the PageTSConfig handling has been changed which broke overloading RTE config by PageTSConfig. This patch removes the obsolete 'properties' check to fix the problem. Resolves: #85173 Related: #85016 Releases: master Change-Id: I85e6d5d9d656ee578451e54f2e226e37cb101fc6 Reviewed-on: https://review.typo3.org/57138 Tested-by:
-
Christian Kuhn authored
The ext:impexp related functional export tests compare with different target .xml file exports depending on the used db engine. This is ugly and pain to maintain. The patch aligns last differences between the generated exports by fixing sorting bugs in fixture db rows and adding an explicit order by at test preparation stage. Additionally, a column type bug in irre_tutorial fixture extension got resolved. The different .xml export file comparison fixtures per db engine are then merged into one and the split logic within tests removed. Change-Id: I429d5127e09c3e3714edae938cb0bf796b3274fd Resolves: #85178 Releases: master Reviewed-on: https://review.typo3.org/57141 Reviewed-by:
-
Christian Kuhn authored
Method BackendUtility::getRecord() returns strings or integer values for number columns like int / bigint. This detail depends on the underlying driver, for instance mysqli returns integers for those fields, while native pdo_mysql and our pdo_pgsql setup return strings for everything. This leads to different xml files when exporting records depending on driver, since GeneralUtility::array2xml() may add type="integer". That's especially nasty for the functional export tests and is one reason we have to maintain dedicated xml fixture files per db driver. During import, the type value does not matter, it needs to be able to cope with both variants anyway. The patch now just forces strings for all to-be-exported row values. Resolves: #85175 Releases: master Change-Id: Ic132d8abd906b34c59279ce025c0bdd65e954672 Reviewed-on: https://review.typo3.org/57140 Reviewed-by:
-
Christian Kuhn authored
Adds a class that auto creates TYPO3 "management" related database columns and indexes based on TCA 'ctrl' information without having them specified in ext_tables.sql. The feature .rst file outlines field details. Goals: * Save extension developers time. * Less copy+paste issues and different general fields definitions. * Reduce number of boilerplate fields in ext_tables.sql. * Bring schema of management fields under core control. Non goals: * No full substitution of ext_tables.sql by TCA: "Business" fields from 'columns' are NOT created automatically. This would require further thoughts and code disentangling. * No new extension API. * No "migration" approach or similar. Notable patch details: * The patch is a revamped version of issue #81234 that has been abandoned. As requested in the review of #81234, the code now hooks in after ext_tables.sql has been parsed into the doctrine schema. * Field defintions of ext_tables.sql take precedence, auto fields are only added if ext_tables.sql does not define a column or index. This makes the patch fully backwards compatible. * No deprecation for obsolete field definitions in ext_tables.sql is logged. * Many core fields are aligned to a central definition and slightly change. For instance "uid" is now always an unsigned int. * Reduce all core's ext_tables.sql files as well as the functional testing related ext_tables.sql files down to the business fields * A relatively huge series of test adaptions: Especially the ext:impexp related functionals now create dumps with differently sorted fields - This is no problem during import. * Field t3_origuid of sys_file_reference has never been registered in TCA as ['ctrl']['origUid'], is thus unused and removed as obsolete. * The extension manager no longer applies possible destructive changes, it only adds missing columns and tables when loading / updating extensions. It however considers *all* ext_tables.sql files, not only the one the extension in question provides. See the important .rst file for details. Change-Id: I640a7c7da3b63bac21a71102f253aa2d1bef4391 Resolves: #85160 Related: #81234 Releases: master Reviewed-on: https://review.typo3.org/57121 Tested-by:
-
Kevin Ditscheid authored
Fix the link browser to not drop the additional link params if editing a link with additional link params set. Resolves: #85040 Releases: master, 8.7 Change-Id: I4c016f701b38e048aa999c4e96365019eae4a237 Reviewed-on: https://review.typo3.org/57009 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Christian Kuhn authored
composer updade typo3/testing-framework The update brings a couple of cleanups and bug fixes and an improved functional test case splitter script now used in bamboo. Resolves: #85171 Releases: master Change-Id: I79e30fd4e93e4a1635a74e225d4801dfb1768ad4 Reviewed-on: https://review.typo3.org/57134 Tested-by:
-
Christian Kuhn authored
The various "AbstractActionTestCase" classes of the functional data handling tests only prepare the scenario, while the extending Test classes of ext:core and ext:workspaces then call parent and add assertions. The abstract test preparations thus must not have @test annotations, they would be executed as casual tests without asserting anything useful. The patch removes those obsolete @test annotations and fixes another test case that had wrong wrong naming and was not executed for a while. Resolves: #85170 Releases: master Change-Id: Ibf6f9ef99f7eaeaeba1374962112d4a342c36567 Reviewed-on: https://review.typo3.org/57133 Tested-by:
-
- Jun 06, 2018
-
-
Christian Kuhn authored
phpunit tends to execute test case files even if the file comes with a broken namespace and can't be autoloaded. The patch hopefully fixes all test case files that are positioned in a wrong folder, has an otherwise broken namespace or is not yet registered as psr-4 require-dev. Resolves: #85169 Releases: master Change-Id: Id8da485b14ab65a883dd90e1a11cfd8e74d85780 Reviewed-on: https://review.typo3.org/57132 Tested-by:
-
- Jun 05, 2018
-
-
Nicole Cordes authored
Currently only the DriverInterface cares about applied filters. The ResourceStorage received a new API function to validate a file or folder object against applied filters as well. This ensures proper validation for objects fetched without driver calls. Resolves: #84908 Releases: master, 8.7 Change-Id: I5e8d35215c99aacfb330fe0eb8cfd9259b9a4199 Reviewed-on: https://review.typo3.org/56844 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Richard Haeser authored
The SEO meta tags that can be set in the page properties, will be rendered in frontend. Resolves: #85147 Releases: master Change-Id: I75e6d8e50b7c8616497ee7075fddcb182551bea4 Reviewed-on: https://review.typo3.org/57117 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
