- Sep 17, 2024
-
-
Benni Mack authored
Change-Id: Iaa9dfd64c2fc419f7745124a098fe3975b1f8b7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86138 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benjamin Kott authored
Resolves: #105000 Releases: main Change-Id: Ia9b7aadb943fc08e5daac1863de2eecffcc3a5dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86137 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <akienast@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Garvin Hicking authored
This reverts commit ad813a0d. Reason for revert: Post-merge, valid concerns were raised that may make follow-ups after a sprint release too hard. The most pressing one being processing via DataHandler and regarding Record Transformation. For details, see the currently unresolved comments in the original patch. A follow-up patch has been created with #104997 which can start the process on finishing the implementation. Main points to address: - DataHandler / Record Transformation (+Tests) - FlexForm Support - Possible multi-selection - Extbase typeconverter implementation so that stored relations can be processed in frontend implementations of these records Releases: main Resolves: #104999 Related: #104997 Reverts: #99911 Change-Id: Ib532b096417d18d89a5695136a28ea594caa518c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86152 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Lina Wolf authored
Releases: main Resolves: #104972 Change-Id: Ieab8aa1bc549bfc2bf07b215ce2adbe944540829 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86101 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Lina Wolf authored
Resolves: #104982 Releases: main Change-Id: I53dcac39d8890bfc124db9a1c72415751fd4a372 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86117 Reviewed-by:
-
Benjamin Kott authored
Login logos provided as SVGs are now rendered inline and can utilize currentColor as fill to allow context awareness. In addition the class .highlight is exposed and sets the fill to the configured highlight color of the login. Resolves: #104989 Releases: main Change-Id: I4c90d4740754fee4e194998057a65a6e38cf7d4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86120 Reviewed-by:
-
Elias Häußler authored
This patch adds iterable types to properties and methods of Symfony ExpressionLanguage providers to assist static analysis tools in extensions that provide custom providers. Resolves: #104991 Releases: main, 12.4 Change-Id: I1291e72cee9b61cdda44cf1f19366acd8e58b970 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86121 Tested-by:
-
Karsten Nowak authored
Use the spread operator for the array_map result in deprecated TSFE->addCacheTags(). Resolves: #104998 Related: #104990 Releases: main Change-Id: Ibd96aa81fd4b9d4a001a33d58b790cad9a6de734 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86133 Reviewed-by:
Sascha Nowak <typo3@saschanowak.me> Reviewed-by:
-
Andreas Kienast authored
The CSS property `pointer-events: none` is removed from form elements to allow text selection and title attributes in read-only fields again. The cursor `not-allowed` is applied to disabled fields only. as readonly fields are not considered disallowed (e.g. text selection is fine). Resolves: #104981 Releases: main Change-Id: I3046f73a0a5c339d8b5111e4b85b86a4e7aaed0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86115 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Georg Ringer authored
The TCA type "country" utilizes the country API provided with #99618 to give integrators a simple way to implement a country selection. Resolves: #99911 Related: #99618 Releases: main Change-Id: Ifee9dcea1114f8522f2884afb4d2dec3100e1a49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77792 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Frank Naegler authored
This patch solves multiple smaller issues with the origin patch. * It's now visible if the page itself was changed or a content on that page * Widget options are now documented in the RST file * The displayed date is the change date of the content element or page (whatever influenced the page to appear in the widget) * Missing language information is added * View webpage now respects the language parameter * The edit content button now opens the correct page * Using the current workspace restriction to fetch `sys_history` records does not work and is replaced by adding a direct equal where condition for the current workspace id * Additionally, some small code quality improvements, e.g., missing strict type checks and wrong cases in function calls Resolves: #104920 Related: #104878 Releases: main Change-Id: I33bdb1019eb5806b1f401201339a4592d2db867a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86019 Tested-by:
-
Sascha Nowak authored
Whenever a record is rendered with the ContentObjectRenderer the cache tag is added automatically. Resolves: #104990 Related: #102422 Releases: main Change-Id: Ieb55c41fbd890692f78d950290fd6cf39761623a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86125 Tested-by:
-
- Sep 16, 2024
-
-
Benni Mack authored
The Image AVIF format is supported by "libgd" since PHP 8.1 which can now be used to create images by GIFBUILDER. See https://en.wikipedia.org/wiki/AVIF Example: page.10 = IMAGE page.10 { file = GIFBUILDER file { backColor = yellow XY = 1024,199 format = avif speed = 8 quality = 44 10 = IMAGE 10.offset = 10,10 10.file = 1:/my-image.jpg } } Resolves: #102353 Releases: main Change-Id: Ibb0697f1c7120ba596ac94f31e51d4863c3999b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81712 Tested-by:
-
Christian Kuhn authored
This reverts commit 3963de08. Reason for revert: Template auto discovery is a feature that needs to designed with a full concept for the entire system in mind and not for one single core detail. It should be part of a lower "near fluid" level. This detail feature can be easily done as an extension if people love it so much that they want it now. Change-Id: I2d1e7eda2c1edfcce910b7ed2f5835508d4a26e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86057 Tested-by:
-
Sascha Nowak authored
Introduce more sophisticated automatic cache tagging in multiple places of the core. Extbase: * A Cache tag is added for the tablename when using findAll() and countAll(). * A Cache tag for the storage pid is added when using th findBy*() and __call() methods ContentObject: * A Cache Tag is added for each records rendered by ContentContentObject and RecordContentObject TypoLink: * A Cache Tag is added for linked pages. This is useful for scenarios like having a page with start and/or end time. When a page links to this kind of pages the link should reflect the correct state. Currently it could happen the target page is "hidden" but the page that linked to it was served from cache and the link was still active. Resources: * A Cache Tag is added when linking to a file. This is useful when a file is replaced or metadata are changed the. This feature is guarded with toggle "frontend.cache.autoTagging" and experimental for now: The feature is still incomplete and there should be a couple more places that add tags. Additionally, some instances may tend to add many tags, which may have a negative impact on performance. Automatic tagging and cache clearing by tag is the way to go, though. But we have to gather additional feedback from the community to gain knowledge in order to determine loose ends and bottlenecks. As such, we decided to bring this feature into the wild now. The feature toggle is by default *disabled* for instances being upgraded from earlier core versions, and *enabled* for newly created instances based on TYPO3 v13. Resolves: #104990 Related: #102422 Releases: main Change-Id: I839ebc5bac7a066fb158a5213d419956937b44dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85778 Tested-by:
-
Lina Wolf authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/86028 readonly site setting definitions were introduced but not mentioned in any changelog entry. Resolves: #104993 Releases: main Change-Id: I563f953ca3e10da32201d0f8c1b4164944052402 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86124 Reviewed-by:
-
Benjamin Franzke authored
In preparation for readonly system settings, settings definitions now suppot a readonly attribute. Releases: main Resolves: #104919 Related: #102799 Change-Id: I4ea22bf7d3f93b895493291993a01b8bf5695275 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86028 Reviewed-by:
Sebastian Iffland <sebastian.iffland@fullhaus.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
-
Benjamin Franzke authored
The module URL, as shown the the user, does not need to contain the colorScheme query parameter that was added in #104868. Releases: main Resolves: #104986 Related: #104868 Change-Id: I47d634f399729de1e26274a7f793a26bcbb85a12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86119 Reviewed-by:
-
Nikita Hovratov authored
The naming of BeforeTcaOverridesEvent is a little unfortunate as it could also be named AfterBaseTcaEvent. It was specifically meant to enable extension authors to add base TCA in a dynamic manner. Thus, it should also benefit from TCA enrichment. This is important for the Content Blocks extension, as it may drop the TCA generation of system columns and let the Core do the heavy lifting. Resolves: #104949 Related: #104311 Releases: main Change-Id: I828c1b18d953071f7509ac0c9784873e03e43a8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86078 Reviewed-by:
-
Andreas Kienast authored
As the color scheme feature, especially dark mode is still experimental, the `PageRenderer` now checks whether the backend user is authenticated before applying the data attribute to control the rendering. The same logic is now applied in the Install Tool running in the backend context, as it wasn't checked whether the feature is enabled before. Resolves: #104985 Releases: main Change-Id: I0b988a0a9a9f3a6a765b1f883aaecc96eeb2626a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86118 Tested-by:
-
Lina Wolf authored
Releases: main Resolves: #104979 Change-Id: If3a27d3f0c3cf90c53fa9d3c6eff62d6467c8321 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86114 Reviewed-by:
-
Frank Naegler authored
This patch removes inline JavaScript to prevent CSP errors, and also remove inline stylings which are not required and useful. Resolves: #104978 Releases: main, 12.4 Change-Id: I62bfbe5b74f26236efa1239cc3a081eac25be75c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86110 Tested-by:
-
Frank Naegler authored
This patch removes a useless inline script to prevent CSP errors. The script shows an info box if the user enters a password, which is required anyway. So it makes no sense to hide the info and make it visible with the first user input. Resolves: #104977 Releases: main, 12.4 Change-Id: Iadb145936e44bcf8aa1e3ab7ed445bad01bd85bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86107 Tested-by:
-
Frank Naegler authored
This patch adds the correct „for“ attribute to select the correct radio button. Resolves: #104976 Releases: main Change-Id: Ia5d323864a9cb37c1a87e217f578635acdaceb6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86106 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- Sep 15, 2024
-
-
Friedemann Altrock authored
The old link lead to a 404 page. Resolves: #104835 Releases: main Change-Id: I741999696712af6e8bf3fafecc73b5938999255c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86108 Tested-by:
Marco Huber <mail@marco-huber.de> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
Garvin Hicking authored
This is needed to showcase the bug reported in issue #104940: A required type=color field cannot be saved/verified. Resolves: #104941 Related: #104940 Releases: main Change-Id: Icfb44500d189ee77342755b08dca240d2c03340d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86049 Tested-by:
-
Andreas Nedbal authored
Resolves: #104968 Releases: main Change-Id: I0ca52db1b2b7ba3162f334c35242cce2b4424211 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86103 Reviewed-by:
-
Stefan Bürk authored
The `symfony/yaml` package is a hard dependency of the TYPO3 Core and ships a dedicated `yaml-lint` binary as entry point for the shipped `LintCommand` class. Most TYPO3 integrators and developers are not aware of that dedicated binary installed along the way and only know about the TYPO3 binary for command execution. As the TYPO3 core relies on YAML files and parsing with an increasing number of implementation and use cases it's good to have linting of these files in available and easy to reach. This change adds the `symfony/yaml` linting command to the TYPO3 binary as feature with corresponding raise of awareness, albeit being a development and pipeline support feature only. The new command can be used from the TYPO3 binary with: bin/typo3 lint:yaml bin/typo3 lint:yaml --help directly in composer and non-composer installations. Resolves: #104973 Releases: main Change-Id: Ic65da691d34dccec2b292a946f59985ceadaf780 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84438 Tested-by:
-
Elias Häußler authored
The TSFE->cacheExpires property was removed in #102422. This patch removes an existing property access and replaces it with its successor in PrepareTypoScriptFrontendRendering middleware. Resolves: #104975 Related: #102422 Releases: main Change-Id: I106209ac5aa896abdd7838f6922cbb20f8411106 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86105 Reviewed-by:
-
Andreas Nedbal authored
The usability of a "OS default" option isn't the greatest. Depending on the active color scheme, the "auto" option doesn't change anything visually. Having the imminent result options left in the dropdown is better. The "OS default" (auto) option is still provided in the User Settings and as default when the feature is initially enabled (and no setting was saved by the user). Resolves: #104942 Releases: main Change-Id: I12e1f48446478a84069299cbb975f6fe176348e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86051 Tested-by:
-
Garvin Hicking authored
This patch adds functional tests to verify the SysNoteRepository fetches proper/valid data to be displayed in widgets for example, and respects personal/foreign/deleted attributes in sys_note records. Resolves: #104898 Related: #104844 Releases: main Change-Id: Ia1d3d16661776785e8840d96f67469eadb7fc154 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86006 Tested-by:
-
Benni Mack authored
Instead of config.sendCacheHeaders which might have your users see the same content for a long time, it is recommended to use config.sendCacheHeadersForSharedCaches = auto instead, because this now sends the following HTTP Header: Cache-Control: max-age=0, s-maxage=12345 where as s-maxage is the number of seconds how long the proxy / CDN is allowed to cache, while the browser/client should never cache this. This way, the proxy can decide on how long to cache things. See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control Resolves: #104914 Releases: main Change-Id: If121df42b22dd0027a8fd17e5bc434c4e67e612a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86007 Reviewed-by:
-
Stefan Bürk authored
With #102422 the new `CacheDataCollector API` has been introduced which also implemented a middleware functional test. Mocking the request to verify that the `withAttribute()` method gets called with the correct identifier and that the passed value is the expected object instance. It seems that PHPUnit relies on type declaration when createing mocks and and eventually returning the same object if the return type matches the object type. During nightly composer minimum version test this fails now. Instead of raising packages and determine which one includes type declaration to let PHPUnit kick in some magic here the request method mock is explicitly set to return the same object when calling the method with the expected value. Resolves: #104971 Related: #102422 Releases: main Change-Id: If3f438f5c62096784d8fd0790f52e4a7d1637b34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86099 Tested-by:
-
Ayke Halder authored
This makes FileClipboardCest check if the content-iframe is reloaded before clicking on a button to open a dropdown-menu. Before this change the button click and opening of the dropdown-menu did sporadically happen in the old iframe-content - and before the iframe-reload. As soon as the iframe reloads, the popup-menu is closed again. The subsequent click on a dropdown-menu-entry therefore fails. Resolves: #104714 Related: #104585 Related: #104702 Releases: main, 12.4, 11.5 Change-Id: Id7fd4d993ab563ab530e8c26f741a4ed0cbeb95d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85744 Tested-by:
-
Stefan Bürk authored
This change adds a integration check which scans for spaces in file and folder names which would otherwise lead to issues on some systems. Resolves: #104923 Related: #104922 Related: #104868 Releases: main, 12.4, 11.5 Change-Id: I8560ebcfae6f959289b3e64ae8292e08e4e7e036 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86038 Tested-by:
-
- Sep 14, 2024
-
-
Garvin Hicking authored
The CKEditor v5 configuration API allows to specify Regular Expression JavaScript objects, for example in :javascript:`editor.config.typing.transformations.extra.from` or :javascript:`editor.config.htmlSupport.allow.name`: When TYPO3 passes YAML configuration of the CKEditor forward to JavaScript, it uses a html-entity encoded representation, which does not allow to utilize Regular Expression objects, and also the CKEditor API method `buildQuotesRegExp()` is not usable in this scenario. This was remedied already for the configuration key :yaml:`htmlSupport` with its sub-keys, so that when a YAML key named :yaml:`pattern` was found, TYPO3 automatically converted that to a proper JavaScript Regular Expression. This is now also possible for the `editor.config.typing.transformations` structure: ``` editor: config: typing: transformations: extra: - { from: { pattern: '(tsconf|t3ts)$'}, to: 'TYPO3 TypoScript TSConfig' } ``` From searching the CKEditor v5 documentation it seems there are no other usages where Regular Expressions are used, but this is not easily revealed. Future places can be added easily. Resolves: #104827 Releases: main, 12.4 Change-Id: Ideeab2b22a177afaba2b434ef0d71920b6c7e296 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85910 Reviewed-by: -
Sybille Peters authored
The page layout module now displays a close button if the query parameters contain returnUrl. This can be used by extension authors, for example in combination with the Fluid backend:moduleLink ViewHelper. The patch also introduces this feature into widgets provided by sysext:sys-note as an example. Resolves: #103789 Releases: main Change-Id: I04c55d5291ef8ceec62eb54500aa6bed3e68aebc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84143 Reviewed-by:
-
Garvin Hicking authored
The database table `sys_file_metadata` set a limit of 45 characters for the `publisher` column (via TCA configuration), which was not enough in some cases, for example: macOS Version 10.14.6 (Build 18G103) Quartz PDFContext The character limit has now been raised to 120 characters. The database column is not (by default) part of an index column, and the table `sys_file_metadata` still has enough column space available to rectify this change. Resolves: #104872 Releases: main Change-Id: I368654544f6d1cda0bfaf8880a86f87f6f658951 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86087 Tested-by:
-
Garvin Hicking authored
Similar to EXT:seo, the sys_note widgets now only soft-depend on EXT:dashboard (as a suggestion). Service registration has been adapted. Resolves: #104959 Related: #104844 Releases: main Change-Id: I4834b0687c2b8edaead0480403c3ac257a0566d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86089 Reviewed-by:
-
Sascha Nowak authored
A new API has been introduced to collect cache tags and their lifetime during frontend rendering. This API is used in the core to collect cache tags from page cache and content object cache. The API is implemented as a new PSR-7 request attribute `frontend.cache.collector` to remove the dependency from TSFE. Every cache tag has a lifetime. The minimum lifetime is calculated from all given cache tags. API users don't have to deal with it individually. The default lifetime for a cache tag is 86400 seconds (24 hours). The current TSFE api is deprecated in favor of the new API as the current API implementation does not allow to set a lifetime and extension authors have to workaround it. The TSFE api will be removed with the next major version. The frontend employs the following strategy: A relatively early middleware adds an empty new cacheDataCollector instance as attribute to request. Extensions rendering code based on database records can then add cache tags t...
-
