- Jan 14, 2018
-
-
Alexander Schnitzler authored
Releases: master Resolves: #83522 Change-Id: Ie1f9db6e3180c1d32e3d8b99e37ff88669ede86d Reviewed-on: https://review.typo3.org/55314 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #83521 Change-Id: I8bd477ccf2ae6fca478b758cf61654a1bec388cd Reviewed-on: https://review.typo3.org/55313 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #83520 Change-Id: Idd10aa62692198f7aa20af1492fb9670149d5ac9 Reviewed-on: https://review.typo3.org/55312 Reviewed-by:
-
- Jan 13, 2018
-
-
Nicole Cordes authored
If a scanAvailablePackages() of the PackageManager is triggered, we need to make sure all possible packagesBasePaths are taken into account. As new extensions might have been downloaded, we need to re-check those possible paths unless all were found. Resolves: #83560 Releases: master, 8.7 Change-Id: I4a65a2f384163b6a3cc3071711e80d88eaf22971 Reviewed-on: https://review.typo3.org/55356 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Nicole Cordes authored
The PackageManager needs to scan over all package location to be able to decide whether a package is available or not. Resolves: #83531 Releases: master, 8.7 Change-Id: Ib21c18a559b4c02d8efce146c8d5addf66b25f1f Reviewed-on: https://review.typo3.org/55326 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Wolfgang Klinger authored
UserTS disableDelete was set for sys_file_metadata globally and therefore also prevented the deletion of translated file metadata. By preventing deletion of sys_file_metadata records only for default language records, the user can remove translated ones again at will. Resolves: #83066 Relates: #71678 Releases: master, 8.7 Change-Id: I3b83a3dd63b02b94bdd34dd8f002436af14ad45d Reviewed-on: https://review.typo3.org/55340 Reviewed-by:
-
Christian Kuhn authored
The extension scanner docs has recently been moved around within core api docs. Update the link within the upgrade module accordingly. Change-Id: Id74a3fa162db63a4257a1d8d2b6b9037bd661467 Resolves: #83558 Releases: master Reviewed-on: https://review.typo3.org/55353 Tested-by:
-
Christian Kuhn authored
Apply a series of CGL whitespace fixes, mostly: * No whitespace after type cast * One space around '=' Change-Id: I6279e083a4bd867bfb70c9567c35b6bab1412043 Resolves: #83557 Releases: master Reviewed-on: https://review.typo3.org/55352 Tested-by:
-
Christian Kuhn authored
Apply various minor indentation CGL fixes, as suggested by scrutinizer-ci, mostly related to places where indentation is done with 1 or 3 spaces instead of 4. Change-Id: Ie3345c7391c0735e8074fd633dd9523616a6b82d Resolves: #83555 Releases: master Reviewed-on: https://review.typo3.org/55350 Reviewed-by:
-
Christian Kuhn authored
This cosmetical CGL change just substitutes all declare(strict_types=1); with declare(strict_types = 1); to be in line with the general 'spaces around =' rule. While that is cosmetical, it makes scrutinizer-ci a bit more happy and prevents it from creating auto-patches for these cases. Change-Id: Ic754b3fd2a0f06624909e6188ed270bd2797745c Resolves: #83554 Releases: master Reviewed-on: https://review.typo3.org/55349 Tested-by:
-
Christian Kuhn authored
Patch renames the context menu options "Export to .t3d" to "Export" and "Import from .t3d" to "Import". The technical format detail is no good additional information and also misleading since xml exports are possible, too. Change-Id: I0d5bb6b1c390a6c74f58d41b06aac935bad82ec0 Resolves: #83552 Releases: master Reviewed-on: https://review.typo3.org/55346 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Wolfgang Klinger authored
Output folder meta information (file count and total file size) next to the folder path in Filelist again. Additionally fix a typo in a condition above. Resolves: #83528 Releases: master, 8.7 Change-Id: I6969966405655d54528059ec937018078caea9d9 Reviewed-on: https://review.typo3.org/55318 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Alexander Schnitzler authored
This patch mainly converts several unit tests with heavy mocking to functional tests with real fixtures instead of 'eval()'ed classes. During that seperation two minor bugs have been fixed: - "resolveValidatorObjectName" tried to find non FQCN validators by checking for a colon, an underscore or a backslash. That way it found shorthand validators like "TYPO3.CMS.Extbase:NotEmpty" and validators without any extension reference. e.g. "NotEmpty". While that check itself is not a problem, the resolver furthermore explodes the validator name by colons, which fails for validator names without extension reference. This has been fixed by an additional elseif. - Another small bug has been fixed in the method "buildBaseValidatorConjunction". While aggregating the validator annotations, the method "parseValidatorAnnotation" is called that returns an array with the annotation information. If the information is built for a method param, the key argumentName is set. However, this is not the case for properties but following code relied on argumentName being present. argumentName is now explicitly set to null if not given. Releases: master Resolves: #83481 Change-Id: I413b85ad905c19f6ae7daef8f5d97aeeab2edb90 Reviewed-on: https://review.typo3.org/55275 Tested-by:
-
Markus Klein authored
Source: http://unicode.org/Public/UNIDATA/UnicodeData.txt Releases: master, 8.7 Resolves: #83541 Change-Id: I0ba23c774f24be120c562239c7665c8a1732cbb1 Reviewed-on: https://review.typo3.org/55334 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Christian Kuhn authored
The recommendation of FolderStructure having index.php and typo3/ folder as links is old fashioned, even if not using composer based instances. The config has no functional meaning in the install tool and can just be dropped. Change-Id: Ie8addd1713cadeb381a11cf9a362ac255da6e72c Resolves: #83550 Releases: master Reviewed-on: https://review.typo3.org/55343 Tested-by:
-
Christian Kuhn authored
One of the environment image tests misses an explicit fixPermissions() call on a created image resulting in potentially broken file permissions on that file. Change-Id: Ib7e9da2269aaabdd9cc815d8ff2f0d3841b45444 Resolves: #83549 Releases: master Reviewed-on: https://review.typo3.org/55342 Tested-by:
-
- Jan 12, 2018
-
-
Reiner Teubner authored
Add a new test for the function specCharsToASCII(). Resolves: #83546 Related: #20612 Releases: master Change-Id: Id255ab953ef7c1865a7db1892b9b5d5fac87c547 Reviewed-on: https://review.typo3.org/55333 Reviewed-by:
Reiner Teubner <rteubner@me.com> Tested-by:
-
Anja Leichsenring authored
Add a matcher that is able to detect hits of method calls that do not comply to a minimum amount of arguments, where new arguments have been introduced or previously optional ones have been made mandatory. Resolves: #83471 Relates: #82899 Releases: master Change-Id: I96eedb06bfcd88a8927902060224b12b64f6f470 Reviewed-on: https://review.typo3.org/55268 Tested-by:
-
Tymoteusz Motylewski authored
intExplode missed an additional parameter which prevents the method from returning array with empty element. Now when doktypesToShowInNewPageDragArea is empty, PageTree API will return empty array. Resolves: #83542 Releases: master Change-Id: I0ebfaef8e1ea782580e0feda59958bb39b0ca483 Reviewed-on: https://review.typo3.org/55335 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Fernandez authored
The directory name for deprecated unit tests are named "Unit_Deprecated" for EXT:core and EXT:form, which is wrong, the tests don't get executed. This patch fixes the names to "UnitDeprecated". Resolves: #83525 Releases: master Change-Id: I2f6f3a70ae4514e58bc885416821cf2aa3340297 Reviewed-on: https://review.typo3.org/55317 Tested-by:
-
- Jan 11, 2018
-
-
Christian Kuhn authored
With the switch from npm install to yarn install we forgot to adapt the test suites. Update plan specs. Change-Id: Ibced9d53a4abf73b33e95027a61263f19cd94e56 Resolves: #83544 Related: #83038 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55336 Tested-by:
-
Andreas Fernandez authored
Resolves: #83537 Releases: master Change-Id: I8da8f31447bd2ca73aa7d7c22a929b918a085da8 Reviewed-on: https://review.typo3.org/55332 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Nicole Cordes authored
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addLLrefForTCAdescr needs a non-empty key as first parameter. Otherwise an exception is thrown but the message shows wrong information. Resolves: #83532 Releases: master Change-Id: I59c44b2b4aafcbbee679662ecab667c85f7a25dc Reviewed-on: https://review.typo3.org/55327 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Jan 10, 2018
-
-
Helmut Hummel authored
Instead of duplicating default extension configuration in DefaultConfiguration.php, we now populate it after LocalConfiguration.php has been written. Benefit is that we don't duplicate configuration and that we even can have other system extensions enabled by default without having to touch anything. Resolves: #83420 Releases: master Change-Id: I4118066e986bc7bab2dcb0cc67dbd4a2d89c70a3 Reviewed-on: https://review.typo3.org/55209 Tested-by:
-
Andreas Fernandez authored
`break-all` breaks the text in the cache menu. Use `break-word` to keep whole words intact. Resolves: #83443 Releases: master, 8.7 Change-Id: I060a3cc3d3461233d93a4b08ff6cf4ec96f0edda Reviewed-on: https://review.typo3.org/55320 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Ralf Zimmermann authored
Add the missing breaking rst for issue #82210. Resolves: #83517 Related: #82210 Releases: master Change-Id: Id157cf0678912a3008705a1fbb64a2014f2fc3f3 Reviewed-on: https://review.typo3.org/55307 Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Jan 09, 2018
-
-
Andreas Fernandez authored
Some values in the Application Information toolbar menu are too long any may exceed the box's width. The CSS is adjusted to break too long strings. Also, for better readability for very long values, the alignment is changed from `middle` to `top`. Resolves: #83443 Releases: master, 8.7 Change-Id: Ia85e92e086525c8f66fd8ab225160dfbdb313a73 Reviewed-on: https://review.typo3.org/55258 Tested-by:
Michael Schams <typo3.mschams@2017.schams.net> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Tim Lochmüller authored
Use local paths for image tests in EXT:install to avoid problems with PHP allow_url_fopen configuration. The "data://" wrapper requires a allow_url_fopen=1 configuration. Resolves: #78117 Releases: master, 8.7 Change-Id: I7b022dc7681f6e2d3344525e624575be7e6037e9 Reviewed-on: https://review.typo3.org/55300 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Dima Nozdrin authored
The field was forgotten during Doctrine migration. See https://review.typo3.org/#/c/47576/ Resolves: #80901 Releases: master, 8.7 Change-Id: I9081d17e18107ec69c8530da2d66f51f65deef4c Reviewed-on: https://review.typo3.org/55309 Reviewed-by:
-
Ralf Zimmermann authored
The form extension now features imports in YAML configuration files via the special toplevel "imports" option. With the help of this feature, form setup and especially form definitions can be reused without copying. Furthermore, the YAML loading has been centralized and slightly extended to meet the requirements of the form framework. The configuration of the form framework has been merged into one file. A follow up patch will rearrange the configuration to improve clarity and understandability. This task heavily depends on the "imports" functionality. Resolves: #82089 Releases: master Change-Id: I44f52572ab2d516949dd017ef1face351b448d65 Reviewed-on: https://review.typo3.org/54210 Tested-by:
-
Steffen Kamper authored
As additional sanitation, accept an empty header for items groups by rendering "-" if none is given. Resolves: #83484 Releases: master, 8.7 Change-Id: Iff733cdcbdba18a52a5430b661fafd9692483659 Reviewed-on: https://review.typo3.org/55285 Reviewed-by:
-
- Jan 08, 2018
-
-
Alexander Schnitzler authored
The class implemented logic to presumably make testing validators more easy. However, a decision on more atomic tests has been made and therefore that abstract test case has been deprecated and will be removed in the future. Releases: master Resolves: #83511 Change-Id: Ic7f071c370acec53d466326344d34ce1334276b4 Reviewed-on: https://review.typo3.org/55298 Tested-by:
-
Frank Naegler authored
karma-firefox-launcher 1.0.1 ❯ 1.1.0 karma-jasmine 1.1.0 ❯ 1.1.1 Resolves: #83492 Releases: master Change-Id: Ib753c1ae70e9361af948ebf197cc05d69aa21f61 Reviewed-on: https://review.typo3.org/55287 Tested-by:
-
Alexander Schnitzler authored
Replace evaled classes with actual fixtures Releases: master Resolves: #83488 Change-Id: Id9b5e3040a8fde8cf260423dfdd1448f6675f09f Reviewed-on: https://review.typo3.org/55284 Tested-by:
Reiner Teubner <reiner.teubner@me.com> Tested-by:
-
Alexander Schnitzler authored
- Replace eval with anonymous classes - Avoid mocks if not necessary Releases: master Resolves: #83485 Change-Id: I5c74f905807b082e6b039c29f475c78d05d0fefa Reviewed-on: https://review.typo3.org/55281 Tested-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
-
Alexander Schnitzler authored
- Replace eval with anonymous classes - Avoid mocks if not necessary Releases: master Resolves: #83482 Change-Id: I38a7b5c78ffbe6f1347e70154eb72077916892bc Reviewed-on: https://review.typo3.org/55277 Tested-by:
-
Alexander Schnitzler authored
Replace eval with anonymous classes Releases: master Resolves: #83487 Change-Id: Ib09ac0ecf9fe5bf3945b46a403be389d2a9ec84d Reviewed-on: https://review.typo3.org/55283 Tested-by:
-
Alexander Schnitzler authored
- Replace eval with anonymous classes - Avoid mocks if not necessary Releases: master Resolves: #83483 Change-Id: Id7fca4bbe43d907378031ce7b8f35ed4a364bcc7 Reviewed-on: https://review.typo3.org/55278 Tested-by:
-
Stefan Neufeind authored
Resolves: #83478 Releases: master Change-Id: Ic7d249deefa4f188c039c2c3f8aa285f4e4effed Reviewed-on: https://review.typo3.org/55272 Tested-by:
-
Frank Naegler authored
Resolves: #83493 Releases: master Change-Id: I4a44da6fcca7462298b54d236e6aa601971de3b6 Reviewed-on: https://review.typo3.org/55289 Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
