From fc4fbc4ae052be0d0bd483cf002706b176110190 Mon Sep 17 00:00:00 2001
From: Christian Kuhn <lolli@schwarzbu.ch>
Date: Tue, 28 Nov 2017 18:55:34 +0100
Subject: [PATCH] [BUGFIX] Hint for 'Check for broken extensions' if install
tool crashes
If the install tool crashes in cards that load ext_* files from extensions,
it currently clears html body and only renders a message "Something went wrong".
This will later become a recovery view which can analyze where and how the
error happened to show the user good option on how to resurrect the instance.
For now, the message is extended a bit linking to the "Upgrade" menu saying
one should use the "Check for broken extensions". This way - until a bigger
solution evolved - we at least have a link to click on, and the user does not
need to fiddle with the url bar of the browser. This is especially useful
in install tool standalone mode where the whole content including the left
main menu is currently substituted by the error message.
Change-Id: I8e1c450949d9f00f8c2e0e1e95a847979973c124
Resolves: #82922
Releases: master
Reviewed-on: https://review.typo3.org/54559
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
---
.../install/Resources/Public/JavaScript/Modules/Router.js | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/typo3/sysext/install/Resources/Public/JavaScript/Modules/Router.js b/typo3/sysext/install/Resources/Public/JavaScript/Modules/Router.js
index ef446d3a39b9..dbf09e6187d3 100644
--- a/typo3/sysext/install/Resources/Public/JavaScript/Modules/Router.js
+++ b/typo3/sysext/install/Resources/Public/JavaScript/Modules/Router.js
@@ -125,8 +125,12 @@ define([
}
} else {
// @todo Recovery tests should be started here
- message = InfoBox.render(Severity.error, 'Something went wrong', '');
- $(this.selectorBody).empty().append(message);
+ var url = this.getUrl(undefined, 'upgrade');
+ message = '<div class="t3js-infobox callout callout-sm callout-danger"><div class="callout-body">'
+ + 'Something went wrong. Please use <b><a href="' + url + '">Check for broken'
+ + ' extensions</a></b> to see if a loaded extension breaks this part of the install tool'
+ + ' and unload it.</div></div>';
+ $(this.selectorBody).empty().html(message);
}
},
--
GitLab