From fc3a6e70da09d8113101dff5091c7a2875c8aa9b Mon Sep 17 00:00:00 2001
From: Peter Niederlag <peter.niederlag@typo3.org>
Date: Wed, 19 Feb 2014 17:17:04 +0100
Subject: [PATCH] [BUGFIX] dont set fePreview=2 with ADMCMD_noBeUser
The workspace preview adds the GET parameter ADMCMD_noBeUser
when requesting the frame for live preview.
$GLOBALS[BE_USER] is unset in index_ts.php when seeing ADMCMD_noBeUser.
In TypoScriptFrontendController fePreview=2 must not be set when
ADMCMD_noBeUser parameter is present to prevent fatal errors on
calling methods on a non-existent $GLOBALS[BE_USER]
Releases: master, 6.2
Resolves: #30643
Change-Id: Idff7febcaaa8b87bd65a993b1860ad378e09b22f
Reviewed-on: http://review.typo3.org/27834
Reviewed-by: Lorenz Ulrich <lorenz.ulrich@visol.ch>
Tested-by: Lorenz Ulrich <lorenz.ulrich@visol.ch>
Reviewed-by: Markus Bucher <markusbucher@gmx.de>
Tested-by: Markus Bucher <markusbucher@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
---
.../Classes/Controller/TypoScriptFrontendController.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php b/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
index 2b6e8e16e3ea..9d3e0f142314 100644
--- a/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
+++ b/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
@@ -1286,7 +1286,7 @@ class TypoScriptFrontendController {
}
}
// The preview flag will be set if a backend user is in an offline workspace
- if (($GLOBALS['BE_USER']->user['workspace_preview'] || GeneralUtility::_GP('ADMCMD_view') || $this->doWorkspacePreview()) && ($this->whichWorkspace() === -1 || $this->whichWorkspace() > 0)) {
+ if (($GLOBALS['BE_USER']->user['workspace_preview'] || GeneralUtility::_GP('ADMCMD_view') || $this->doWorkspacePreview()) && ($this->whichWorkspace() === -1 || $this->whichWorkspace() > 0) && (!GeneralUtility::_GP('ADMCMD_noBeUser'))) {
// Will show special preview message.
$this->fePreview = 2;
}
--
GitLab