From faed1d021bd1759e8b3a011f5c894ea3b7a17d66 Mon Sep 17 00:00:00 2001
From: Henrik Ziegenhain <henrik@ziegenhain.me>
Date: Thu, 19 Jan 2023 12:22:58 +0100
Subject: [PATCH] [BUGFIX] Avoid non string argument to str_starts_with()
TranslateViewHelper needs to cast $id to string to avoid
feeding an int to str_starts_with().
Resolves: #99637
Releases: main
Change-Id: Icf432eed5b983daea4a8feafaa2e040d2a7aa7f0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77495
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
---
typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php b/typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php
index 2d8a98af9525..55d959a07607 100644
--- a/typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php
+++ b/typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php
@@ -145,7 +145,8 @@ final class TranslateViewHelper extends AbstractViewHelper
$id = $key;
}
- if ((string)$id === '') {
+ $id = (string)$id;
+ if ($id === '') {
throw new Exception('An argument "key" or "id" has to be provided', 1351584844);
}
--
GitLab