From f59b3ad7e8b999da7c30bf745457563160d6b32b Mon Sep 17 00:00:00 2001
From: Mona Muzaffar <mona.muzaffar@gmx.de>
Date: Mon, 30 Jan 2017 13:10:16 +0100
Subject: [PATCH] [BUGFIX] Temporaryly skip tests repeatedly failing
Change-Id: I7d2492782ff1a7203beafc37a1b4457bf65735a2
Resolves: #79552
Releases: master
Reviewed-on: https://review.typo3.org/51468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
---
.../Backend/Formhandler/ElementsBasicCest.php | 23 +++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/ElementsBasicCest.php b/typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/ElementsBasicCest.php
index 5140169ae4a9..bc585dcbd5c0 100644
--- a/typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/ElementsBasicCest.php
+++ b/typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/ElementsBasicCest.php
@@ -295,11 +295,15 @@ class ElementsBasicCest
}
/**
- * @param \TYPO3\CMS\Core\Tests\Acceptance\Step\Backend\Admin $I
- * @param \TYPO3\CMS\Core\Tests\Acceptance\Support\Helper\Formhandler $formhandler
+ * @param \TYPO3\CMS\Components\TestingFramework\Core\Acceptance\Step\Backend\Admin $I
+ * @param \TYPO3\CMS\Components\TestingFramework\Core\Acceptance\Support\Helper\Formhandler $formhandler
+ * @skip
*/
public function checkThatBrowserSideValidationWorks_EvalDate(Admin $I, Formhandler $formhandler)
{
+ $this->skip("Instable Test is skipped due to repeated failure");
+ //@todo fix this test
+
$this->waitForFormReady($I);
$fieldData = [
'input_6 eval=date' => [
@@ -492,6 +496,9 @@ class ElementsBasicCest
public function checkThatValidationWorks_evalTimesec(Admin $I, Formhandler $formhandler)
{
+ $this->skip("Instable Test is skipped due to repeated failure");
+ //@todo fix this test
+
$this->waitForFormReady($I);
$testData = [
'input_18 eval=timesec' => [
@@ -519,7 +526,7 @@ class ElementsBasicCest
}
/**
- * @param \TYPO3\CMS\Core\Tests\Acceptance\Support\Helper\Formhandler $formhandler
+ * @param \TYPO3\CMS\Components\TestingFramework\Core\Acceptance\Support\Helper\Formhandler $formhandler
* @param $fieldData
*/
protected function runTests(Formhandler $formhandler, $fieldData)
@@ -533,7 +540,7 @@ class ElementsBasicCest
}
/**
- * @param \TYPO3\CMS\Core\Tests\Acceptance\Step\Backend\Admin $I
+ * @param \TYPO3\CMS\Components\TestingFramework\Core\Acceptance\Step\Backend\Admin $I
*/
protected function waitForFormReady(Admin $I)
{
@@ -542,4 +549,12 @@ class ElementsBasicCest
$I->click($editRecordLinkCssPath);
$I->waitForText('Edit Form', 3, 'h1');
}
+
+ /**
+ * From Codeception/Scenario
+ */
+ protected function skip($message)
+ {
+ throw new \PHPUnit_Framework_SkippedTestError($message);
+ }
}
--
GitLab