From ecbac33e2f7e60490acc9cfa967e645285997904 Mon Sep 17 00:00:00 2001
From: Christian Kuhn <lolli@schwarzbu.ch>
Date: Sun, 3 Dec 2017 00:40:52 +0100
Subject: [PATCH] [BUGFIX] ContentObjectRendereTest: Undefined constant NL
A data provider uses the not defined constant "NL". PHP 7.2
throws warnings on this. Warnings from data providers do not
lead to failing tests, still this is ugly and pollutes test
runs with warnings in the head part.
Change-Id: I3b09ce51d675cf3097967c074511eaf0a53cf8f9
Resolves: #83194
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54907
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
---
.../ContentObjectRendererTest.php | 27 +++++++++----------
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php b/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php
index 19f6860c5bdf..64e5fbc89dfc 100644
--- a/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php
+++ b/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php
@@ -3397,29 +3397,28 @@ class ContentObjectRendererTest extends \TYPO3\TestingFramework\Core\Unit\UnitTe
['', 'TEXT']
],
'multiple nested tags with classes' => [
- NL . '<div class="typo3">' .
- NL . '<p>A <b>BOLD<\b> WORD.</p>' .
- NL . '<p>AN <i>ITALIC<\i> WORD.</p>' .
- NL . '</div>',
- NL . '<div class="typo3">' .
- NL . '<p>A <b>bold<\b> word.</p>' .
- NL . '<p>An <i>italic<\i> word.</p>' .
- NL . '</div>',
+ '<div class="typo3">'
+ . '<p>A <b>BOLD<\b> WORD.</p>'
+ . '<p>AN <i>ITALIC<\i> WORD.</p>'
+ . '</div>',
+ '<div class="typo3">'
+ . '<p>A <b>bold<\b> word.</p>'
+ . '<p>An <i>italic<\i> word.</p>'
+ . '</div>',
$case,
[
- [NL, $case],
- [NL, $case],
+ ['', $case],
+ ['', $case],
['A ', $case],
['bold', $case],
[' word.', $case],
- [NL, $case],
+ ['', $case],
['An ', $case],
['italic', $case],
[' word.', $case],
- [NL, $case],
+ ['', $case],
],
- [NL, NL, 'A ', 'BOLD', ' WORD.',
- NL, 'AN ', 'ITALIC', ' WORD.', NL]
+ [ '', '', 'A ', 'BOLD', ' WORD.', '', 'AN ', 'ITALIC', ' WORD.', '']
],
];
}
--
GitLab