From eb5d1f2baba912d43689b95eab9f751f69d23536 Mon Sep 17 00:00:00 2001
From: Torben Hansen <derhansen@gmail.com>
Date: Sun, 12 Mar 2023 19:40:22 +0100
Subject: [PATCH] [TASK] Use constructor property promotion in
OpenDocumentController
This change adds constructor property promotion in ext:opendocs
`OpenDocumentController`.
Resolves: #100150
Releases: main
Signed-off-by: Torben Hansen <derhansen@gmail.com>
Change-Id: Idf60edda6c9231723cfb5d6dc9bddcf64a150fb4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78104
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
---
.../Classes/Controller/OpenDocumentController.php | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/typo3/sysext/opendocs/Classes/Controller/OpenDocumentController.php b/typo3/sysext/opendocs/Classes/Controller/OpenDocumentController.php
index 99cb7cbda1b1..d5eb46dce083 100644
--- a/typo3/sysext/opendocs/Classes/Controller/OpenDocumentController.php
+++ b/typo3/sysext/opendocs/Classes/Controller/OpenDocumentController.php
@@ -31,15 +31,10 @@ use TYPO3\CMS\Opendocs\Service\OpenDocumentService;
*/
class OpenDocumentController
{
- protected OpenDocumentService $documents;
- protected OpendocsToolbarItem $toolbarItem;
-
public function __construct(
- OpenDocumentService $documents,
- OpendocsToolbarItem $toolbarItem
+ protected readonly OpenDocumentService $documents,
+ protected readonly OpendocsToolbarItem $toolbarItem
) {
- $this->documents = $documents;
- $this->toolbarItem = $toolbarItem;
}
/**
--
GitLab