From e95feacbfbc0242b85b263e9f9d026aa737e4440 Mon Sep 17 00:00:00 2001
From: Georg Ringer <georg.ringer@gmail.com>
Date: Tue, 7 Nov 2017 08:08:42 +0100
Subject: [PATCH] [BUGFIX] Add label to page ID field in PageLinkHandler
Add the missing label and adopt styling of the additional
field which allows to link to a page by providing the page ID.
Resolves: #82888
Releases: master, 8.7
Change-Id: I33ab92f235391add5d3da00a0251ee11eb936933
Reviewed-on: https://review.typo3.org/54575
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
---
.../Language/locallang_browse_links.xlf | 3 +++
.../Classes/LinkHandler/PageLinkHandler.php | 20 +++++++++----------
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/typo3/sysext/lang/Resources/Private/Language/locallang_browse_links.xlf b/typo3/sysext/lang/Resources/Private/Language/locallang_browse_links.xlf
index be1868e6a9dd..f7fe96692031 100644
--- a/typo3/sysext/lang/Resources/Private/Language/locallang_browse_links.xlf
+++ b/typo3/sysext/lang/Resources/Private/Language/locallang_browse_links.xlf
@@ -117,6 +117,9 @@
<trans-unit id="folderSelector">
<source>Folder selector</source>
</trans-unit>
+ <trans-unit id="page_id">
+ <source>Page ID</source>
+ </trans-unit>
</body>
</file>
</xliff>
diff --git a/typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php b/typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php
index 2999fdde5103..15f6a6e0e117 100644
--- a/typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php
+++ b/typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php
@@ -279,17 +279,17 @@ class PageLinkHandler extends AbstractLinkHandler implements LinkHandlerInterfac
if (!empty($configuration['pageIdSelector.']['enabled'])) {
$this->linkAttributes[] = 'pageIdSelector';
$fieldDefinitions['pageIdSelector'] = '
- <tr>
- <td>
- <label>
- ' . htmlspecialchars($this->getLanguageService()->getLL('page_id')) . ':
+ <form class="form-horizontal"><div class="form-group form-group-sm">
+ <label class="col-xs-4 control-label">
+ ' . htmlspecialchars($this->getLanguageService()->getLL('page_id')) . '
</label>
- </td>
- <td colspan="3">
- <input type="text" size="6" name="luid" id="luid" /> <input class="btn btn-default t3js-pageLink" type="submit" value="'
- . htmlspecialchars($this->getLanguageService()->getLL('setLink')) . '" />
- </td>
- </tr>';
+ <div class="col-xs-2">
+ <input type="number" size="6" name="luid" id="luid" class="form-control" />
+ </div>
+ <div class="col-xs-6">
+ <input class="btn btn-default t3js-pageLink" type="submit" value="' . htmlspecialchars($this->getLanguageService()->getLL('setLink')) . '" />
+ </div>
+ </div></form>';
}
return $fieldDefinitions;
}
--
GitLab