From d56e4a51403f9235b881caa5e24798d81ffcc298 Mon Sep 17 00:00:00 2001
From: Andreas Wolf <dev@a-w.io>
Date: Fri, 22 Dec 2017 17:06:52 +0100
Subject: [PATCH] =?UTF-8?q?[BUGFIX]=20Don=E2=80=99t=20show=20deprecations?=
=?UTF-8?q?=20as=20"success"=20flash=20messages?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Change-Id: I48eba81412e314bb8ee013ef38ecbdb32a14ed96
Resolves: #83416
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55202
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
---
typo3/sysext/core/Classes/Error/ErrorHandler.php | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/typo3/sysext/core/Classes/Error/ErrorHandler.php b/typo3/sysext/core/Classes/Error/ErrorHandler.php
index 80885d962689..27f0c9aee599 100644
--- a/typo3/sysext/core/Classes/Error/ErrorHandler.php
+++ b/typo3/sysext/core/Classes/Error/ErrorHandler.php
@@ -18,6 +18,7 @@ use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use TYPO3\CMS\Core\Database\ConnectionPool;
use TYPO3\CMS\Core\Log\LogLevel;
+use TYPO3\CMS\Core\Messaging\FlashMessage;
use TYPO3\CMS\Core\TimeTracker\TimeTracker;
use TYPO3\CMS\Core\Utility\GeneralUtility;
@@ -113,13 +114,16 @@ class ErrorHandler implements ErrorHandlerInterface, LoggerAwareInterface
switch ($errorLevel) {
case E_USER_ERROR:
case E_RECOVERABLE_ERROR:
+ // no $flashMessageSeverity, as there will be no flash message for errors
$severity = 2;
break;
case E_USER_WARNING:
case E_WARNING:
+ $flashMessageSeverity = FlashMessage::WARNING;
$severity = 1;
break;
default:
+ $flashMessageSeverity = FlashMessage::NOTICE;
$severity = 0;
}
$logTitle = 'Core: Error handler (' . TYPO3_MODE . ')';
@@ -150,7 +154,7 @@ class ErrorHandler implements ErrorHandlerInterface, LoggerAwareInterface
\TYPO3\CMS\Core\Messaging\FlashMessage::class,
$message,
$errorLevels[$errorLevel],
- $severity
+ $flashMessageSeverity
);
/** @var $flashMessageService \TYPO3\CMS\Core\Messaging\FlashMessageService */
$flashMessageService = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Messaging\FlashMessageService::class);
--
GitLab