From cfa9bcbd5355f4a69224fc6b42d1e4b1902983c0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sascha=20L=C3=B6ffler?= <lsascha@gmail.com>
Date: Fri, 16 Mar 2018 15:54:12 +0100
Subject: [PATCH] [TASK] Make FileSizeValidatorTest.php notice free
Resolves: #84350
Releases: master
Change-Id: I4ab0027f86517f6f607a891a2ad5a1417935af1b
Reviewed-on: https://review.typo3.org/56231
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
---
.../Unit/Mvc/Validation/FileSizeValidatorTest.php | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/typo3/sysext/form/Tests/Unit/Mvc/Validation/FileSizeValidatorTest.php b/typo3/sysext/form/Tests/Unit/Mvc/Validation/FileSizeValidatorTest.php
index 37da2f77afee..f75246944b8f 100644
--- a/typo3/sysext/form/Tests/Unit/Mvc/Validation/FileSizeValidatorTest.php
+++ b/typo3/sysext/form/Tests/Unit/Mvc/Validation/FileSizeValidatorTest.php
@@ -1,4 +1,5 @@
<?php
+declare(strict_types = 1);
namespace TYPO3\CMS\Form\Tests\Unit\Mvc\Validation;
/*
@@ -18,17 +19,13 @@ use TYPO3\CMS\Core\Resource\File;
use TYPO3\CMS\Core\Resource\ResourceStorage;
use TYPO3\CMS\Form\Mvc\Validation\Exception\InvalidValidationOptionsException;
use TYPO3\CMS\Form\Mvc\Validation\FileSizeValidator;
+use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
/**
* Test case
*/
-class FileSizeValidatorTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
+class FileSizeValidatorTest extends UnitTestCase
{
- /**
- * Subject is not notice free, disable E_NOTICES
- */
- protected static $suppressNotices = true;
-
/**
* @test
*/
@@ -78,7 +75,7 @@ class FileSizeValidatorTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCa
->disableOriginalConstructor()
->getMock();
- $file = new File(['identifier' => '/foo', 'size' => '1'], $mockedStorage);
+ $file = new File(['identifier' => '/foo', 'name'=> 'bar.txt', 'size' => '1'], $mockedStorage);
$this->assertTrue($validator->validate($file)->hasErrors());
}
@@ -97,7 +94,7 @@ class FileSizeValidatorTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCa
->disableOriginalConstructor()
->getMock();
- $file = new File(['identifier' => '/foo', 'size' => '1048577'], $mockedStorage);
+ $file = new File(['identifier' => '/foo', 'name' => 'bar.txt', 'size' => '1048577'], $mockedStorage);
$this->assertTrue($validator->validate($file)->hasErrors());
}
--
GitLab