From c9fef8b48aeec63259ae7cdf68c1c2fecaeba93a Mon Sep 17 00:00:00 2001
From: Torben Hansen <derhansen@gmail.com>
Date: Tue, 23 Aug 2022 19:09:33 +0200
Subject: [PATCH] [!!!][TASK] Remove TODAYS_SPECIAL error constant
The constant `TODAYS_SPECIAL` has never been used in TYPO3
core and also 3rd party extensions in TER do not make
use of it. The constant can therefore be removed safely
from the class.
Resolves: #98195
Releases: main
Change-Id: I187817b2641d97c48832e757ad0de710e49ce31f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75538
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
---
typo3/sysext/core/Classes/SysLog/Error.php | 8 ----
...8195-RemoveTODAYS_SPECIALErrorConstant.rst | 37 +++++++++++++++++++
2 files changed, 37 insertions(+), 8 deletions(-)
create mode 100644 typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98195-RemoveTODAYS_SPECIALErrorConstant.rst
diff --git a/typo3/sysext/core/Classes/SysLog/Error.php b/typo3/sysext/core/Classes/SysLog/Error.php
index 40f09b163532..c3fe01045323 100644
--- a/typo3/sysext/core/Classes/SysLog/Error.php
+++ b/typo3/sysext/core/Classes/SysLog/Error.php
@@ -27,12 +27,4 @@ class Error
public const SYSTEM_ERROR = 2;
public const SECURITY_NOTICE = 3;
public const WARNING = 4;
-
- /*
- * 100 is a code, which has been introduced by Kasper in his "Todays special" commit:
- * @see https://github.com/typo3/typo3/commit/7496d6d033
- *
- * @todo The constant should either be renamed or replaced completely in the future
- */
- public const TODAYS_SPECIAL = 100;
}
diff --git a/typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98195-RemoveTODAYS_SPECIALErrorConstant.rst b/typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98195-RemoveTODAYS_SPECIALErrorConstant.rst
new file mode 100644
index 000000000000..2b6ea23d852e
--- /dev/null
+++ b/typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98195-RemoveTODAYS_SPECIALErrorConstant.rst
@@ -0,0 +1,37 @@
+.. include:: /Includes.rst.txt
+
+.. _breaking-98195-1661274247:
+
+=======================================================
+Breaking: #98195 - Remove TODAYS_SPECIAL error constant
+=======================================================
+
+See :issue:`98195`
+
+Description
+===========
+
+The constant :php:`TODAYS_SPECIAL` in :php:`\TYPO3\CMS\Core\SysLog\Error` has never been
+used in TYPO3 core and is therefore removed without replacement.
+
+
+Impact
+======
+
+3rd party extensions using the extension will fail with a PHP error.
+
+
+Affected installations
+======================
+
+3rd party extensions who use the :php:`TODAYS_SPECIAL` constant.
+
+
+Migration
+=========
+
+3rd party extensions using the :php:`TODAYS_SPECIAL` constant should replace
+all usages with the integer value `100` or use a custom class with a user
+defined constant.
+
+.. index:: Backend, PHP-API, NotScanned, ext:core
--
GitLab