From c7f042e51345a8f92e7d25c246cfc768659a8839 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20B=C3=BCrk?= <stefan@buerk.tech>
Date: Fri, 28 Jun 2024 13:30:02 +0200
Subject: [PATCH] [TASK] Avoid implicitly nullable class method parameter in
`EXT:felogin`
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator or adding a null
tyype to an union type definition. [1]
This prepares the way towards PHP 8.4 compatibility.
[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
Resolves: #104246
Releases: main, 12.4, 11.5
Change-Id: Id7713c10014da20bcd4e7976e64434c71d319bda
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84989
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
---
.../felogin/Classes/Controller/PasswordRecoveryController.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php b/typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php
index c89c39b71196..cacf2ad899d9 100644
--- a/typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php
+++ b/typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php
@@ -77,7 +77,7 @@ class PasswordRecoveryController extends AbstractLoginFormController
* @throws StopActionException
* @throws \TYPO3\CMS\Extbase\Configuration\Exception\InvalidConfigurationTypeException
*/
- public function recoveryAction(string $userIdentifier = null)
+ public function recoveryAction(?string $userIdentifier = null)
{
if (empty($userIdentifier)) {
return $this->htmlResponse();
--
GitLab