diff --git a/typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php b/typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php index 2d12496868c697797827f9c24cb75d4746ccfa72..4b6295fcedd66ae4cb7dfd2343adaa0bcaf55f92 100644 --- a/typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php +++ b/typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php @@ -86,16 +86,16 @@ $EM_CONF[$_EXTKEY] = ' . $emConf . '; || !isset($emConf['constraints']['conflicts']) || !isset($emConf['constraints']['suggests']) ) { if (!isset($emConf['constraints']) || !isset($emConf['constraints']['depends'])) { - $emConf['constraints']['depends'] = $this->stringToDependency($emConf['dependencies']); - if ((string)$emConf['PHP_version'] !== '') { + $emConf['constraints']['depends'] = $this->stringToDependency($emConf['dependencies'] ?? ''); + if (isset($emConf['PHP_version']) && (string)$emConf['PHP_version'] !== '') { $emConf['constraints']['depends']['php'] = $emConf['PHP_version']; } - if ((string)$emConf['TYPO3_version'] !== '') { + if (isset($emConf['TYPO3_version']) && (string)$emConf['TYPO3_version'] !== '') { $emConf['constraints']['depends']['typo3'] = $emConf['TYPO3_version']; } } if (!isset($emConf['constraints']) || !isset($emConf['constraints']['conflicts'])) { - $emConf['constraints']['conflicts'] = $this->stringToDependency($emConf['conflicts']); + $emConf['constraints']['conflicts'] = $this->stringToDependency($emConf['conflicts'] ?? ''); } if (!isset($emConf['constraints']) || !isset($emConf['constraints']['suggests'])) { $emConf['constraints']['suggests'] = []; diff --git a/typo3/sysext/extensionmanager/Tests/Unit/Utility/EmConfUtilityTest.php b/typo3/sysext/extensionmanager/Tests/Unit/Utility/EmConfUtilityTest.php index 2d9ee242235db0054a7afdd0f8207574e0461e53..5b98cca06f280f4a230e768778916fb63609a0b2 100644 --- a/typo3/sysext/extensionmanager/Tests/Unit/Utility/EmConfUtilityTest.php +++ b/typo3/sysext/extensionmanager/Tests/Unit/Utility/EmConfUtilityTest.php @@ -14,15 +14,14 @@ namespace TYPO3\CMS\Extensionmanager\Tests\Unit\Utility; * The TYPO3 project - inspiring people to share! */ +use TYPO3\CMS\Extensionmanager\Utility\EmConfUtility; +use TYPO3\TestingFramework\Core\Unit\UnitTestCase; + /** * Test case */ -class EmConfUtilityTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase +class EmConfUtilityTest extends UnitTestCase { - /** - * Subject is not notice free, disable E_NOTICES - */ - protected static $suppressNotices = true; /** * @test @@ -33,7 +32,7 @@ class EmConfUtilityTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase 'extKey' => 'key', 'EM_CONF' => [], ]; - $fixture = new \TYPO3\CMS\Extensionmanager\Utility\EmConfUtility(); + $fixture = new EmConfUtility(); $emConf = $fixture->constructEmConf($extensionData); $this->assertContains('Extension Manager/Repository config file for ext', $emConf); } @@ -57,7 +56,7 @@ class EmConfUtilityTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase 'suggests' => [], ], ]; - $fixture = new \TYPO3\CMS\Extensionmanager\Utility\EmConfUtility(); + $fixture = new EmConfUtility(); $this->assertEquals($expected, $fixture->fixEmConf($input)); } @@ -81,7 +80,7 @@ class EmConfUtilityTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase 'suggests' => [], ], ]; - $fixture = new \TYPO3\CMS\Extensionmanager\Utility\EmConfUtility(); + $fixture = new EmConfUtility(); $this->assertEquals($expected, $fixture->fixEmConf($input)); } }