diff --git a/typo3/sysext/backend/Resources/Public/JavaScript/GridEditor.js b/typo3/sysext/backend/Resources/Public/JavaScript/GridEditor.js index 37783910f3e2a62c3d9b7d735f00e7e599724931..69ce3a4a1f1d0776dfe72fdcc0374d6d87d39080 100644 --- a/typo3/sysext/backend/Resources/Public/JavaScript/GridEditor.js +++ b/typo3/sysext/backend/Resources/Public/JavaScript/GridEditor.js @@ -387,7 +387,7 @@ define(['jquery', 'TYPO3/CMS/Backend/Modal', 'TYPO3/CMS/Backend/Severity', 'boot }, { text: $(this).data('button-ok-text') || TYPO3.lang['button.ok'] || 'OK', - btnClass: 'btn-' + Modal.getSeverityClass(Severity.notice), + btnClass: 'btn-' + Severity.getCssClass(Severity.notice), name: 'ok' } ]); diff --git a/typo3/sysext/backend/Resources/Public/JavaScript/Modal.js b/typo3/sysext/backend/Resources/Public/JavaScript/Modal.js index dd57af51ecb6d03aa27501acc988e877070c4355..5ad6a966aae6efc4da87308110cb7220e546e2eb 100644 --- a/typo3/sysext/backend/Resources/Public/JavaScript/Modal.js +++ b/typo3/sysext/backend/Resources/Public/JavaScript/Modal.js @@ -76,28 +76,13 @@ define(['jquery', * @param {int} severity use constants from Severity.* * @returns {String} * @private + * @deprecated */ Modal.getSeverityClass = function(severity) { - var severityClass; - switch (severity) { - case Severity.notice: - severityClass = 'notice'; - break; - case Severity.ok: - severityClass = 'success'; - break; - case Severity.warning: - severityClass = 'warning'; - break; - case Severity.error: - severityClass = 'danger'; - break; - case Severity.info: - default: - severityClass = 'info'; - break; + if (console) { + console.warn('Modal.getSeverityClass() is deprecated and will be removed with TYPO3 v9, please use Severity.getCssClass()'); } - return severityClass; + return Severity.getCssClass(severity); }; /** @@ -124,7 +109,7 @@ define(['jquery', }, { text: $(this).data('button-ok-text') || TYPO3.lang['button.ok'] || 'OK', - btnClass: 'btn-' + Modal.getSeverityClass(severity), + btnClass: 'btn-' + Severity.getCssClass(severity), name: 'ok' } ]; @@ -203,7 +188,7 @@ define(['jquery', currentModal.find('.modal-body').html(content); } - currentModal.addClass('t3-modal-' + Modal.getSeverityClass(severity)); + currentModal.addClass('t3-modal-' + Severity.getCssClass(severity)); if (buttons.length > 0) { for (i = 0; i<buttons.length; i++) { var button = buttons[i]; @@ -319,7 +304,7 @@ define(['jquery', }, { text: $element.data('button-ok-text') || 'OK', - btnClass: 'btn-' + Modal.getSeverityClass(severity), + btnClass: 'btn-' + Severity.getCssClass(severity), trigger: function() { Modal.currentModal.trigger('modal-dismiss'); evt.target.ownerDocument.location.href = $element.data('href') || $element.attr('href'); diff --git a/typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js b/typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js index 68342f0b499a2f62f7f538e13062b03967059095..719768adebd0afe0efa3f7321342e83e7ec17ef4 100644 --- a/typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js +++ b/typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js @@ -65,7 +65,7 @@ define(['jquery', Severity.error, [{ text: TYPO3.lang['button.ok'] || 'OK', - btnClass: 'btn-' + Modal.getSeverityClass(Severity.error), + btnClass: 'btn-' + Severity.getCssClass(Severity.error), name: 'ok', active: true }] diff --git a/typo3/sysext/backend/Resources/Public/JavaScript/Severity.js b/typo3/sysext/backend/Resources/Public/JavaScript/Severity.js index 85bc23b80805181081bed9124c8a8cf3d0c19ca4..1df1ffaa37c84a75acd97c263f1d8d1ce0e5e8e3 100644 --- a/typo3/sysext/backend/Resources/Public/JavaScript/Severity.js +++ b/typo3/sysext/backend/Resources/Public/JavaScript/Severity.js @@ -30,7 +30,7 @@ define(function () { } // fetch object from outer frame - if (top && top.TYPO3.Severity) { + if (top && top.TYPO3 && top.TYPO3.Severity) { return top.TYPO3.Severity; } } catch (e) { @@ -56,6 +56,34 @@ define(function () { error: 2 }; + /** + * Gets the CSS class for the severity + * + * @param {Number} severity + * @returns {String} + */ + Severity.getCssClass = function(severity) { + var severityClass; + switch (severity) { + case Severity.notice: + severityClass = 'notice'; + break; + case Severity.ok: + severityClass = 'success'; + break; + case Severity.warning: + severityClass = 'warning'; + break; + case Severity.error: + severityClass = 'danger'; + break; + case Severity.info: + default: + severityClass = 'info'; + } + return severityClass; + }; + // attach to global frame TYPO3.Severity = Severity; diff --git a/typo3/sysext/core/Documentation/Changelog/master/Deprecation-73442-ModalGetSeverityClassHasBeenMovedToTheSeverityModule.rst b/typo3/sysext/core/Documentation/Changelog/master/Deprecation-73442-ModalGetSeverityClassHasBeenMovedToTheSeverityModule.rst new file mode 100644 index 0000000000000000000000000000000000000000..68bcf39b9b03b60a6a3c13dc547ffe6d8965ed6f --- /dev/null +++ b/typo3/sysext/core/Documentation/Changelog/master/Deprecation-73442-ModalGetSeverityClassHasBeenMovedToTheSeverityModule.rst @@ -0,0 +1,26 @@ +================================================================================== +Deprecation: #73442 - Modal.getSeverityClass has been moved to the Severity module +================================================================================== + +Description +=========== + +The method :js:`Modal.getSeverityClass` has been moved to :js:`Severity.getCssClass`. :js:`Modal.getSeverityClass` has been marked as deprecated. + + +Impact +====== + +Calling :js:`Modal.getSeverityClass` will trigger a console warning in the browser. + + +Affected Installations +====================== + +All 3rd party extensions using :js:`Modal.getSeverityClass` are affected. + + +Migration +========= + +Change the calls to :js:`Severity.getCssClass(severity)`. \ No newline at end of file